[ci] Fix shellcheck issues

Author: adangel

.ci/inc/regression-tester.inc

@@ -19,6 +19,7 @@ function regression_tester_setup_ci() {
 
     gpg --batch --yes --decrypt --passphrase="GnxdjywUEPveyCD1RLiTd7t8CImnefYr" \
         --output .ci/files/public-env .ci/files/public-env.gpg
+    # shellcheck disable=SC1091
     source .ci/files/public-env >/dev/null 2>&1
     rm .ci/files/public-env
 
@@ -41,7 +42,7 @@ function regression_tester_setup_ci() {
 function regression_tester_uploadBaseline() {
     local pmdcodeUrl="https://pmd-code.org/pmd-regression-tester/"
     local baseline_branch="${PMD_CI_BRANCH:-$PMD_CI_TAG}"
-    pmd_ci_log_debug "$FUNCNAME branch=${baseline_branch}"
+    pmd_ci_log_debug "${FUNCNAME[0]} branch=${baseline_branch}"
 
     pmd_ci_log_info "Generating and uploading baseline for pmdtester (${baseline_branch})..."
     pushd ..
@@ -50,34 +51,34 @@ function regression_tester_uploadBaseline() {
     bundle exec pmdtester \
         --mode single \
         --local-git-repo ./pmd \
-        --patch-branch ${baseline_branch} \
+        --patch-branch "${baseline_branch}" \
         --patch-config ./pmd/.ci/files/all-java.xml \
         --list-of-project ./pmd/.ci/files/project-list.xml --html-flag \
         --error-recovery
-    pushd target/reports
+    pushd target/reports || { echo "Directory 'target/reports' doesn't exist"; exit 1; }
     BRANCH_FILENAME="${baseline_branch/\//_}"
-    zip -q -r ${BRANCH_FILENAME}-baseline.zip ${BRANCH_FILENAME}/
+    zip -q -r "${BRANCH_FILENAME}-baseline.zip" "${BRANCH_FILENAME}/"
     # ssh-key for pmd-code.org is setup already by pmd_ci_setup_secrets_ssh
-    scp ${BRANCH_FILENAME}-baseline.zip [email protected]:/httpdocs/pmd-regression-tester/
+    scp "${BRANCH_FILENAME}-baseline.zip" [email protected]:/httpdocs/pmd-regression-tester/
     pmd_ci_log_success "Successfully uploaded ${BRANCH_FILENAME}-baseline.zip to ${pmdcodeUrl}"
-    popd
-    popd
+    popd || exit 1
+    popd || exit 1
 }
 
 #
 # Execute danger, which executes pmd-regression-tester (via Dangerfile).
 #
 function regression_tester_executeDanger() {
-    pmd_ci_log_debug "$FUNCNAME"
+    pmd_ci_log_debug "${FUNCNAME[0]}"
 
     # Create a corresponding remote branch locally
-    if ! git show-ref --verify --quiet refs/heads/${PMD_CI_BRANCH}; then
-        git fetch --no-tags --depth=1 origin +refs/heads/${PMD_CI_BRANCH}:refs/remotes/origin/${PMD_CI_BRANCH}
-        git branch ${PMD_CI_BRANCH} origin/${PMD_CI_BRANCH}
+    if ! git show-ref --verify --quiet "refs/heads/${PMD_CI_BRANCH}"; then
+        git fetch --no-tags --depth=1 origin "+refs/heads/${PMD_CI_BRANCH}:refs/remotes/origin/${PMD_CI_BRANCH}"
+        git branch "${PMD_CI_BRANCH}" "origin/${PMD_CI_BRANCH}"
         pmd_ci_log_debug "Created local branch ${PMD_CI_BRANCH}"
     fi
     # Fetch more commits of the PR for danger and regression tester
-    git fetch --no-tags --depth=50 origin +$(git rev-parse HEAD^2):
+    git fetch --no-tags --depth=50 origin "+$(git rev-parse HEAD^2):"
     # Fetch more commits from master branch for regression tester
     if [[ "${PMD_CI_BRANCH}" != "master" ]]; then
         git fetch --no-tags --depth=50 origin +master: