-
Notifications
You must be signed in to change notification settings - Fork 283
Bug fix S3fifo race condition #22156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cpegeric
wants to merge
45
commits into
matrixorigin:main
Choose a base branch
from
cpegeric:s3fifo-reborn-noghost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+459
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… s3fifo-race-main
You are nearing your monthly Qodo Merge usage quota. For more information, please visit here. PR Code Suggestions ✨No code suggestions found for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #21838
What this PR does / why we need it:
fix race condition
PR Type
Bug fix
Description
Fix S3-FIFO cache race conditions with mutex protection
Replace atomic operations with mutex-protected reference counting
Add double-free protection and panic checks for deallocated buffers
Implement proper thread-safe item deletion and eviction
Changes diagram
Changes walkthrough 📝
7 files
Replace atomic with mutex for thread safety
Update cache operations and path deletion
Rewrite S3-FIFO with mutex-based synchronization
Add mutex protection to queue operations
Change Release method to return boolean
Handle Release return value properly
Remove redundant retain/release calls in callbacks
4 files
Add panic tests for deallocated buffers
Update test interface and allocation runs
Update tests for new cache structure
Add tests for sharded map functionality
1 files
New thread-safe sharded map implementation