-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Adds detail report around requests made by AI bots #23793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x-dev
Are you sure you want to change the base?
Conversation
1c2ed65 to
a3746a7
Compare
e7920ce to
f622e04
Compare
9f6fa80 to
833aceb
Compare
19a3fe9 to
785cf6d
Compare
2e69688 to
5ba49b7
Compare
0ec9857 to
a53140a
Compare
| $bindBase = $logAggregator->getGeneralQueryBindParams(); | ||
|
|
||
| $sql = sprintf( | ||
| "SELECT * FROM (SELECT bot.bot_name, log_action.name AS url, COUNT(*) AS requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a ranking style query with the usual Others limitation here?
Currently,y this is completely unbound and just fetches everything, to be later truncated based on the configuration values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually was thinking about that in the first place, but didn't want to add too much complexity. But I guess as soon as someone, tracking millions of different page urls or downloads, tries to start using this it can cause trouble 🤔
Shall we create a follow up issue to add that later, so we can deliver this one faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up sounds great 👍
273e682 to
570a609
Compare
Description
Checklist
Review