Feedback from @michalkleiner

Author: tzi

core/Updates/5.6.0-b2.php

@@ -29,6 +29,7 @@ public function getMigrations(Updater $updater)
     {
         return [
             $this->migration->db->addColumn('segment', 'starred', 'TINYINT(1) NOT NULL DEFAULT 0'),
+            $this->migration->db->addColumn('segment', 'starred_by', 'VARCHAR(100)'),
         ];
     }
 

core/Updates/5.6.0-b3.php

@@ -22,7 +22,7 @@ final class Version
      * The current Matomo version.
      * @var string
      */
-    public const VERSION = '5.6.0-b3';
+    public const VERSION = '5.6.0-b2';
 
     public const MAJOR_VERSION = 5;
 

core/Version.php

@@ -353,9 +353,10 @@ public function add(
      * Stars a stored segment.
      *
      * @param int $idSegment
+     * @return array{result: boolean, starred_by: string}
      * @throws Exception if the user is not logged in or does not have the required permissions.
      */
-    public function star(int $idSegment): ?array
+    public function star(int $idSegment): array
     {
         $segment = $this->getSegmentOrFail($idSegment);
         $this->checkUserCanEditOrDeleteSegment($segment);
@@ -377,9 +378,10 @@ public function star(int $idSegment): ?array
      * Unstars a stored segment.
      *
      * @param int $idSegment
+     * @return array{result: boolean}
      * @throws Exception if the user is not logged in or does not have the required permissions.
      */
-    public function unstar(int $idSegment): ?array
+    public function unstar(int $idSegment): array
     {
         $segment = $this->getSegmentOrFail($idSegment);
         $this->checkUserCanEditOrDeleteSegment($segment);

plugins/SegmentEditor/API.php

@@ -147,7 +147,7 @@ public function testUpdateSegment()
         $this->clearReArchiveList();
 
         $updatedSegment = array(
-            'idsegment' => '' . $idSegment2,
+            'idsegment' => (string) $idSegment2,
             'name' =>   'NEW name',
             'definition' =>  'searches==0',
             'hash' => md5('searches==0'),

plugins/SegmentEditor/tests/Integration/SegmentEditorTest.php

@@ -46,12 +46,12 @@ describe("SegmentSelectorEditorTest", function () {
         expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_open');
     });
 
-  it("should unstar all segments", async function() {
-    await page.click('.segmentList li:nth-child(2) .starSegment');
-    await page.click('.segmentList li:nth-child(3) .starSegment');
-    await page.click('.segmentList li:nth-child(4) .starSegment');
-    expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_unstarred');
-  });
+    it("should unstar all segments", async function() {
+      await page.click('.segmentList li:nth-child(2) .starSegment');
+      await page.click('.segmentList li:nth-child(3) .starSegment');
+      await page.click('.segmentList li:nth-child(4) .starSegment');
+      expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_unstarred');
+    });
 
     it("should star last segment", async function() {
       await page.click('.segmentList li:last-child .starSegment');