Add and Update tests

Author: tzi

plugins/SegmentEditor/tests/Integration/SegmentEditorTest.php

@@ -82,6 +82,7 @@ public function testAddAndGetSimpleSegment()
             'enable_only_idsite' => '0',
             'auto_archive' => '0',
             'ts_last_edit' => null,
+            'starred' => '0',
             'deleted' => '0',
         );
 
@@ -112,6 +113,7 @@ public function testAddAndGetAnotherSegment()
             'enable_only_idsite' => '1',
             'auto_archive' => '1',
             'ts_last_edit' => null,
+            'starred' => '0',
             'deleted' => '0',
         );
         unset($segment['ts_created']);
@@ -145,7 +147,7 @@ public function testUpdateSegment()
         $this->clearReArchiveList();
 
         $updatedSegment = array(
-            'idsegment' => $idSegment2,
+            'idsegment' => '' . $idSegment2,
             'name' =>   'NEW name',
             'definition' =>  'searches==0',
             'hash' => md5('searches==0'),
@@ -155,6 +157,7 @@ public function testUpdateSegment()
             'ts_last_edit' => Date::now()->getDatetime(),
             'ts_created' => Date::now()->getDatetime(),
             'login' => Piwik::getCurrentUserLogin(),
+            'starred' => '0',
             'deleted' => '0',
         );
         API::getInstance()->update(
@@ -178,11 +181,29 @@ public function testUpdateSegment()
 
         $this->assertEquals($newSegment, $updatedSegment);
 
-        // Check the other segmenet was not updated
+        // Check the other segment was not updated
         $newSegment = API::getInstance()->get($idSegment1);
         $this->assertEquals($newSegment['name'], $nameSegment1);
     }
 
+    public function testStarUnstarSegment()
+    {
+        // Set up initial conditions
+        $idSegment = API::getInstance()->add('hello', 'searches==0');
+        $segment = API::getInstance()->get($idSegment);
+        $this->assertEquals('0', $segment['starred']);
+
+        // Star segment
+        API::getInstance()->star($idSegment);
+        $starredSegment = API::getInstance()->get($idSegment);
+        $this->assertEquals('1', $starredSegment['starred']);
+
+        // Unstar segment
+        API::getInstance()->unstar($idSegment);
+        $unstarredSegment = API::getInstance()->get($idSegment);
+        $this->assertEquals('0', $unstarredSegment['starred']);
+    }
+
     public function testDeleteSegment()
     {
         $this->expectNotToPerformAssertions();

plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js

@@ -46,6 +46,18 @@ describe("SegmentSelectorEditorTest", function () {
         expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_open');
     });
 
+  it("should unstar all segments", async function() {
+    await page.click('.segmentList li:nth-child(2) .starSegment');
+    await page.click('.segmentList li:nth-child(3) .starSegment');
+    await page.click('.segmentList li:nth-child(4) .starSegment');
+    expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_unstarred');
+  });
+
+    it("should star last segment", async function() {
+      await page.click('.segmentList li:last-child .starSegment');
+      expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('1_selector_starred');
+    });
+
     it("should open segment editor when edit link clicked for existing segment", async function() {
         await page.evaluate(function() {
             $('.segmentList .editSegment:first').click()

plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_1_selector_open.png

@@ -172,6 +172,7 @@ private function checkSegmentAvailable(string $definition, string $name, bool $s
                     'auto_archive' => 1,
                     'ts_last_edit' => null,
                     'deleted' => 0,
+                    'starred' => 0,
                 ],
             ];
         }