Simplify visitor profile popup url parameter (#23794)

* Simplify visitor profile popup url parameter
* Adds UI test for visitor profile action

Author: sgiehl

plugins/UserId/javascripts/rowaction.js

@@ -24,12 +24,18 @@
         var visitorId = this.getRowMetadata($(tr)).idvisitor || '';
         visitorId = encodeURIComponent(visitorId);
         if (visitorId.length > 0) {
-            DataTable_RowAction.prototype.openPopover.apply(this, ['module=Live&action=getVisitorProfilePopup&visitorId=' + visitorId]);
+            DataTable_RowAction.prototype.openPopover.apply(this, [visitorId]);
         }
     };
 
     DataTable_RowActions_VisitorDetails.prototype.doOpenPopover = function (urlParam) {
-        Piwik_Popover.createPopupAndLoadUrl(urlParam, _pk_translate('Live_VisitorProfile'), 'visitor-profile-popup');
+        var legacyUrlMatch = urlParam.match(/^module=Live&action=getVisitorProfilePopup&visitorId=([a-f0-9]{16})$/i);
+        if (legacyUrlMatch && legacyUrlMatch.length === 2) {
+            urlParam = legacyUrlMatch[1];
+        }
+        if (urlParam.match(/^[a-f0-9]{16}$/i)) {
+            Piwik_Popover.createPopupAndLoadUrl('module=Live&action=getVisitorProfilePopup&visitorId=' + urlParam, _pk_translate('Live_VisitorProfile'), 'visitor-profile-popup');
+        }
     };
 
     DataTable_RowActions_Registry.register({

plugins/UserId/tests/UI/UserId_spec.js

@@ -16,13 +16,24 @@ describe("UserId", function () {
     expect(await page.screenshotSelector('#widgetUserIdgetUsers')).to.matchImage('report');
   });
 
-    it('should switch to table with engagement metrics', async function () {
-      await page.click('.activateVisualizationSelection > span');
-      await page.click('.tableIcon[data-footer-icon-id=tableAllColumns]');
-      await page.mouse.move(-10, -10);
-      await page.waitForNetworkIdle();
-      expect(await page.screenshotSelector('#widgetUserIdgetUsers')).to.matchImage('report_engagement');
+  it('should switch to table with engagement metrics', async function () {
+    await page.click('.activateVisualizationSelection > span');
+    await page.click('.tableIcon[data-footer-icon-id=tableAllColumns]');
+    await page.mouse.move(-10, -10);
+    await page.waitForNetworkIdle();
+    expect(await page.screenshotSelector('#widgetUserIdgetUsers')).to.matchImage('report_engagement');
   });
 
-
+  it('should correctly open the visitor profile', async function () {
+    var rowToMatch = 'td.label:contains(user1):first';
+    await (await page.jQuery('table.dataTable tbody ' + rowToMatch)).hover();
+    await page.waitForTimeout(100);
+    await (await page.jQuery(rowToMatch + ' a.actionvisitorDetails:visible')).hover();
+    await (await page.jQuery(rowToMatch + ' a.actionvisitorDetails:visible')).click();
+    await page.mouse.move(-10, -10);
+    await page.waitForTimeout(250);
+    await page.waitForNetworkIdle();
+    expect(await page.getWholeCurrentUrl()).to.match(/&popover=RowAction%243AvisitorDetails%243A[a-f0-9]{16}$/);
+    expect(await page.screenshotSelector('#Piwik_Popover')).to.matchImage('visitor_profile_popup');
+  });
 });