using value from global.ini 'data_comparison_segment_limit' as the limit

Author: chippison

core/Config.php

@@ -188,6 +188,7 @@ public function getClientSideOptions()
             'action_title_category_delimiter' => $general['action_title_category_delimiter'],
             'are_ads_enabled' => Advertising::isAdsEnabledInConfig($general),
             'autocomplete_min_sites' => $general['autocomplete_min_sites'],
+            'data_comparison_segment_limit' => $general['data_comparison_segment_limit'],
             'datatable_export_range_as_day' => $general['datatable_export_range_as_day'],
             'datatable_row_limits' => $this->getDatatableRowLimits(),
             'enable_general_settings_admin' => Controller::isGeneralSettingsAdminEnabled(),

plugins/SegmentEditor/javascripts/Segmentation.js

@@ -110,7 +110,7 @@ Segmentation = (function($) {
             self.checkIfComparedSegmentsHasReachedLimit();
         };
         segmentation.prototype.checkIfComparedSegmentsHasReachedLimit = function() {
-            const limit = 6;
+            const limit = piwik.config.data_comparison_segment_limit;
             const comparisonService = window.CoreHome.ComparisonsStoreInstance;
             const comparedSegmentsLength = comparisonService.getSegmentComparisons().length;
             console.log('these are the available segments: ',this.availableSegments);
@@ -120,7 +120,7 @@ Segmentation = (function($) {
               if (comparedSegmentsLength >= limit) {
                 console.log('limit reached');
                 $(this).addClass('no-click');
-                $(this).parent().attr('title', _pk_translate('General_MaximumNumberOfSegmentsComparedIs', [6]));
+                $(this).parent().attr('title', _pk_translate('General_MaximumNumberOfSegmentsComparedIs', [limit]));
               } else {
                 console.log('removing class');
                 $(this).removeClass('no-click');