Skip to content

Remove IDisposable pattern where not needed #894

@masesdevelopers

Description

@masesdevelopers

This is a known problem that does not depends directly from KNet: the classes developed in this project applies the IDisposable pattern where it is necessary, however most classes are generated from JNetReflector which adds the needed interfaces and superclasses. The Headers class is correctly defined following the one defined in the JVM:
https://github.com/masesgroup/KNet/blob/75395a6977d617eb6b05964fa6814e0db76deca6/src/net/KNet/Generated/Org/Apache/Kafka/Common/Header/Headers.cs#L32
Iterable is a class defined in JNet to support the foreach operations in C#: it has a deep inheritance hierarchy that ultimately leads to a class implementing IDisposable. The best place for this discussion is in JNet or is ancestor in the hierarchy.

Originally posted by @masesdevelopers in #1460

Metadata

Metadata

Labels

.NETPull requests that update .net codeJNetJNet related issueJNetReflectorJNetReflector related issuebugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions