From 6eab28a77011347ff53778407a89755a646389cb Mon Sep 17 00:00:00 2001 From: Ilia Burakov Date: Wed, 12 Nov 2025 23:29:37 -0500 Subject: [PATCH 1/2] Enables more code analyzers Configures the project to use a higher level of code analysis, and disables specific Roslyn analyzers that are deemed unnecessary or too verbose for the project's needs. This ensures a higher standard of code quality and consistency through more comprehensive static analysis. --- .editorconfig | 3 +++ Directory.Build.props | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 9e4e954..b0098bf 100644 --- a/.editorconfig +++ b/.editorconfig @@ -16,6 +16,9 @@ dotnet_diagnostic.CS1998.severity = suggestion # Reason: it could be too verbose to use it everywhere, but this is a good reminder dotnet_diagnostic.CA1848.severity = none +# CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled +dotnet_diagnostic.CA1873.severity = none + # CA1716: Rename namespace Constants so that it no longer conflicts with the reserved language keyword 'Shared'. # Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. # Reason: we decided to keep it as is for now diff --git a/Directory.Build.props b/Directory.Build.props index 176421f..782e778 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -4,7 +4,7 @@ true - 9-all + 10-all true From df28224baa27e65e8082606ec5448d8d3d96b9af Mon Sep 17 00:00:00 2001 From: Ilia Burakov Date: Thu, 13 Nov 2025 12:34:05 +0800 Subject: [PATCH 2/2] Update .editorconfig Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .editorconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/.editorconfig b/.editorconfig index b0098bf..becec00 100644 --- a/.editorconfig +++ b/.editorconfig @@ -17,6 +17,7 @@ dotnet_diagnostic.CS1998.severity = suggestion dotnet_diagnostic.CA1848.severity = none # CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled +# Reason: logging performance is not critical in our context, and this warning is too aggressive dotnet_diagnostic.CA1873.severity = none # CA1716: Rename namespace Constants so that it no longer conflicts with the reserved language keyword 'Shared'.