Don't require mobile beacons to be loaded to work.

Author: magico13

NotInMyBackYard/ModuleMobileBeacon.cs

@@ -25,34 +25,7 @@ public bool StrictRequirementsMet
                     return false;
                 }
 
-                return SoftRequirementsMet;
-            }
-        }
-
-        /// <summary>
-        /// Checks that there is a Science Lab and an Antenna on the ship
-        /// </summary>
-        //[KSPField(guiActive = true, guiName = "Mobile Beacon Ready")]
-        public bool SoftRequirementsMet
-        {
-            get
-            {
-                //check for a lab on the vessel
-                if (!vessel.Parts.Exists(p => p.Modules.Contains(nameof(ModuleScienceLab))))
-                {
-                    return false;
-                }
-                //Check for an antenna on the vessel
-                if (!vessel.Parts.Exists(p => p.Modules.Contains(nameof(ModuleDataTransmitter))))
-                {
-                    return false;
-                }
-                //Has an Engineer aboard
-                if (!vessel.GetVesselCrew().Exists(c => c.trait == "Engineer"))
-                {
-                    return false;
-                }
-                return true;
+                return Active;
             }
         }
 
@@ -87,7 +60,7 @@ public double Range
         {
             get
             {
-                return 2000;
+                return NotInMyBackYard.MobileBeaconRange;
             }
             set { }
         }
@@ -96,9 +69,8 @@ public bool Active
         {
             get
             {
-                return SoftRequirementsMet;
+                return NotInMyBackYard.MobileBeaconRequirementsMet(vessel);
             }
-
             set { }
         }
 

NotInMyBackYard/NotInMyBackYard.cs

@@ -12,6 +12,7 @@ public class NotInMyBackYard : MonoBehaviour
         protected Button.ButtonClickedEvent originalCallback;
 
         public List<IBeacon> StaticBeacons { get; set; } = new List<IBeacon>();
+        public static double MobileBeaconRange { get; set; } = 2000;
 
         public void Start()
         {
@@ -53,25 +54,27 @@ protected void NewRecoveryFunction(Vessel vessel)
             IBeacon closestBeacon = null; //Used for if we're not in range of any beacons
             double shortestDistance = double.PositiveInfinity;
 
-            
-
             foreach (IBeacon beacon in GetAllBeacons())
             {
-                if (!beacon.Active)
+                if (!beacon.Active || beacon.Range <= 0)
                 {
                     continue;
                 }
                 double distance = beacon.GreatCircleDistance(vessel);
+                double adjustedDistance = distance - beacon.Range;
+
+                Debug.Log($"[NIMBY] {beacon.Name} is {(distance / 1000).ToString("N2")}({(adjustedDistance / 1000).ToString("N2")})km away.");
+
                 if (beacon.CanRecoverVessel(vessel))
                 {
                     originalCallback.Invoke();
                     return;
                 }
                 else
                 {
-                    if (distance > 0 && distance < shortestDistance) //the > 0 checks that it isn't the active vessel
+                    if (distance > 0 && adjustedDistance < shortestDistance) //the > 0 checks that it isn't the active vessel
                     {
-                        shortestDistance = distance;
+                        shortestDistance = adjustedDistance;
                         closestBeacon = beacon;
                     }
                 }
@@ -84,7 +87,8 @@ protected void NewRecoveryFunction(Vessel vessel)
             string closestMessage = "There are no Recovery Beacons nearby.";
             if (closestBeacon != null)
             {
-                closestMessage = $"Closest Recovery Beacon is {closestBeacon.Name} and is {(shortestDistance / 1000).ToString("N2")}km away.";
+                double dist = closestBeacon.GreatCircleDistance(vessel) / 1000;
+                closestMessage = $"Closest Recovery Beacon is {closestBeacon.Name} and is {(dist).ToString("N2")}km away ({(dist-closestBeacon.Range/1000).ToString("N2")}km to edge of Beacon's range).";
             }
 
             PopupDialog.SpawnPopupDialog(new Vector2(), new Vector2(), "tooFarPopup",
@@ -99,18 +103,25 @@ public IList<IBeacon> GetAllBeacons()
 
 
             //find all vessels that have a mobile beacon module
-            foreach (Vessel vessel in FlightGlobals.Vessels.Where(v => v.Parts.Exists(p => p.Modules.Contains(nameof(ModuleMobileRecoveryBeacon))))) //this all requires it to be loaded to function. Ideally we wouldn't require that
+            foreach (Vessel vessel in FlightGlobals.Vessels)
             {
                 //make sure it's active
                 IEnumerable<ModuleMobileRecoveryBeacon> modules;
-                if ((modules = vessel.Parts.Select(p => p.Modules.GetModule<ModuleMobileRecoveryBeacon>())) != null)
+                if (vessel.loaded && (modules = vessel.Parts.Select(p => p.Modules.GetModule<ModuleMobileRecoveryBeacon>())) != null)
                 {
+                    Debug.Log($"[NIMBY] {vessel.GetDisplayName()} has module");
                     IBeacon active = modules.FirstOrDefault(m => m.Active);
                     if (active != null)
                     {
+                        Debug.Log($"[NIMBY] Module is Active.");
                         beacons.Add(active);
                     }
                 }
+                else if (MobileBeaconRequirementsMet(vessel))
+                {
+                    Debug.Log($"[NIMBY] Adding unloaded Beacon for {vessel.GetDisplayName()}.");
+                    beacons.Add(new UnloadedMobileBeacon(vessel));
+                }
             }
             Debug.Log($"[NIMBY] Counting {staticBeacons} static beacons and {beacons.Count - staticBeacons} mobile beacons.");
             return beacons;
@@ -130,6 +141,40 @@ public static double DefaultGreatCircleDistance(double radius, double latitude1,
 
             return Math.Sqrt(d * d);
         }
+
+        public static bool MobileBeaconRequirementsMet(Vessel vessel)
+        {
+            //Check that it's on Kerbin/Earth/whatever
+            if (vessel.mainBody != Planetarium.fetch.Home)
+            {
+                return false;
+            }
+            //check for the module on the vessel
+            if (!vessel.protoVessel.protoPartSnapshots.Exists(p => p.modules.Exists(m => m.moduleName == nameof(ModuleMobileRecoveryBeacon))))
+            {
+                //Debug.Log($"[NIMBY] {vessel.GetDisplayName()} doesn't have a recovery module.");
+                return false;
+            }
+            //check for a lab on the vessel
+            if (!vessel.protoVessel.protoPartSnapshots.Exists(p => p.modules.Exists(m => m.moduleName == nameof(ModuleScienceLab))))
+            {
+                //Debug.Log($"[NIMBY] {vessel.GetDisplayName()} doesn't have a science lab.");
+                return false;
+            }
+            //Check for an antenna on the vessel
+            if (!vessel.protoVessel.protoPartSnapshots.Exists(p => p.modules.Exists(m => m.moduleName == nameof(ModuleDataTransmitter))))
+            {
+                //Debug.Log($"[NIMBY] {vessel.GetDisplayName()} doesn't have an antenna.");
+                return false;
+            }
+            //Has an Engineer aboard
+            if (!vessel.GetVesselCrew().Exists(c => c.trait == "Engineer"))
+            {
+                //Debug.Log($"[NIMBY] {vessel.GetDisplayName()} doesn't have an engineer.");
+                return false;
+            }
+            return true;
+        }
     }
 
     //Start in the Flight Scene only, every time it's loaded

NotInMyBackYard/NotInMyBackYard.csproj

@@ -53,6 +53,7 @@
     <Compile Include="ModuleMobileBeacon.cs" />
     <Compile Include="NotInMyBackYard.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="UnloadedMobileBeacon.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 

NotInMyBackYard/UnloadedMobileBeacon.cs

@@ -0,0 +1,78 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace NotInMyBackYard
+{
+    public class UnloadedMobileBeacon : IBeacon
+    {
+        private Vessel _vessel = null;
+        public string Name
+        {
+            get
+            {
+                return _vessel.GetDisplayName();
+            }
+            set { }
+        }
+
+        public double Latitude
+        {
+            get
+            {
+                return _vessel.latitude;
+            }
+            set { }
+        }
+
+        public double Longitude
+        {
+            get
+            {
+                return _vessel.longitude;
+            }
+            set { }
+        }
+
+        public double Range
+        {
+            get
+            {
+                return NotInMyBackYard.MobileBeaconRange;
+            }
+            set { }
+        }
+
+        public bool Active
+        {
+            get
+            {
+                return NotInMyBackYard.MobileBeaconRequirementsMet(_vessel);
+            }
+
+            set { }
+        }
+
+        public UnloadedMobileBeacon(Vessel vessel)
+        {
+            _vessel = vessel;
+        }
+
+
+        public bool CanRecoverVessel(Vessel vessel)
+        {
+            return vessel.id != _vessel.id && GreatCircleDistance(vessel.mainBody.Radius, vessel.latitude, vessel.longitude) < Range;
+        }
+
+        public double GreatCircleDistance(double radius, double latitude, double longitude)
+        {
+            return NotInMyBackYard.DefaultGreatCircleDistance(radius, Latitude, Longitude, latitude, longitude);
+        }
+
+        public double GreatCircleDistance(Vessel vessel)
+        {
+            return GreatCircleDistance(vessel.mainBody.Radius, vessel.latitude, vessel.longitude);
+        }
+    }
+}