From f0e962dee884ca43b603ed5f5f1796c8705e899d Mon Sep 17 00:00:00 2001 From: David Alger Date: Fri, 23 Sep 2016 14:49:34 -0500 Subject: [PATCH] Removing environment specific switch from tool Toolchains should work uniformly regardless of what environment they are run within. That is, with the same settings, composer should do the same things everywhere it is run. Should someone not want file-marshaling to run when deploying Magento ECE, they should add `"magento-deploystrategy": "none"` to the `extra` section of their composer config. In a recent setup where I prepped an existing site to deploy into the ECE environment, I was forced to explicitly request the use of the `copy` strategy in my composer.json (using same setting as noted above) to workaround this seemingly arbitrary condition which was added to this module at the behest of the platform.sh and/or Magento team(s). --- src/MagentoHackathon/Composer/Magento/Installer.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/MagentoHackathon/Composer/Magento/Installer.php b/src/MagentoHackathon/Composer/Magento/Installer.php index deef73e7..2b590035 100644 --- a/src/MagentoHackathon/Composer/Magento/Installer.php +++ b/src/MagentoHackathon/Composer/Magento/Installer.php @@ -175,10 +175,6 @@ public function __construct(IOInterface $io, Composer $composer, $type = 'magent $this->isForced = (bool)$extra['magento-force']; } - if (false !== getenv('MAGENTO_CLOUD_PROJECT')) { - $this->setDeployStrategy('none'); - } - if (isset($extra['magento-deploystrategy'])) { $this->setDeployStrategy((string)$extra['magento-deploystrategy']); }