Skip to content

Conversation

@flymoonai
Copy link

Apple now requires SDWebImage to include a privacy manifest (PrivacyInfo.xcprivacy). SDWebImage added this in version 5.18.7.

This PR updates:

  • SDWebImage: 5.15.5 → ~> 5.19
  • SDWebImageWebPCoder: 0.11.0 → ~> 0.14

Tested: Verified that pod install resolves correctly and the project builds with SDWebImage 5.21.4 and SDWebImageWebPCoder 0.15.0.

References:

@cla-assistant
Copy link

cla-assistant bot commented Nov 29, 2025

CLA assistant check
All committers have signed the CLA.

@nhsprite
Copy link
Collaborator

nhsprite commented Dec 1, 2025

Really appreciate your contribution! Please confirm to our contribution guide here: guide
image

@MoonfaceX
Copy link
Collaborator

Generally LGTM, there are two issues need to be deal with

  1. Pls follow https://github.com/lynx-family/tools-shared/blob/main/docs/COMMIT_MESSAGE_FORMAT.md to amend ur commit msg
  2. Integration Test failed, @jianliang00 could you help to find out why the version is resolved to 0.0.1-alpha

@jianliang00
Copy link
Contributor

Generally LGTM, there are two issues need to be deal with

  1. Pls follow https://github.com/lynx-family/tools-shared/blob/main/docs/COMMIT_MESSAGE_FORMAT.md to amend ur commit msg
  2. Integration Test failed, @jianliang00 could you help to find out why the version is resolved to 0.0.1-alpha

The "0.0.1-alpha" build is a placeholder version for testing and is unrelated to the failure.
The root cause is a version mismatch of SDWebImage between the Podfile and Podfile.lock.
Before the patch lands, please update the Podfile.lock here first: https://github.com/lynx-family/integrating-lynx-demo-projects/blob/main/ios/HelloLynxObjc/Podfile.lock

Summary of change:
Update SDWebImage and SDWebImageWebPCoder to use flexible version
constraints (~> 5.19 and ~> 0.14 respectively) instead of pinned
versions (5.15.5 and 0.11.0).
@flymoonai flymoonai force-pushed the ios-third-party-sdk branch from fece906 to ad0465b Compare December 1, 2025 15:00
@flymoonai
Copy link
Author

Generally LGTM, there are two issues need to be deal with

  1. Pls follow https://github.com/lynx-family/tools-shared/blob/main/docs/COMMIT_MESSAGE_FORMAT.md to amend ur commit msg
  2. Integration Test failed, @jianliang00 could you help to find out why the version is resolved to 0.0.1-alpha

I have fixed the commit message, from @jianliang00 suggestion I can also do a follow up PR int hat other repo for the HelloLynxObjc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants