[BugFix] Fix podspec target xcconfig override in jojo #3948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianliang00
force-pushed
the
shadow/p/ci_lynx/xcconfig-override
branch
from
1da0c55 to
ed2d7a6
Compare
Different from cocoapods, some pod building system handles subspec's `pod_target_xcconfig`, it just override the parent one. For example:
``` podspec
Pod::Spec.new do |p|
p.pod_target_xcconfig = {
"CLANG_CXX_LANGUAGE_STANDARD" => "gnu++17",
# ...
}
p.subspec "Framework" do |sp|
sp.pod_target_xcconfig = {
"HEADER_SEARCH_PATHS" => ".."
}
# ...
```
gnu++17 may won't take effect in `Framework` subspec, in some special build system.
issue: m-6794750008
jianliang00
force-pushed
the
shadow/p/ci_lynx/xcconfig-override
branch
from
ed2d7a6 to
49bcc3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.