LUT-29924 : fix AccessDeniedException when trying to duplicate a step

obfromevi · ryahiaoui · commit a662af0b0e87 · 2025-07-11T11:18:40.000+02:00
diff --git a/src/java/fr/paris/lutece/plugins/forms/web/admin/FormStepJspBean.java b/src/java/fr/paris/lutece/plugins/forms/web/admin/FormStepJspBean.java
@@ -379,16 +379,15 @@ public String doDuplicateStep( HttpServletRequest request ) throws AccessDeniedE
         }
 
         int nIdForm = -1;
-        checkUserPermission( Form.RESOURCE_TYPE, String.valueOf( nIdForm ), FormsResourceIdService.PERMISSION_MODIFY, request, ACTION_CREATE_STEP );
-        checkWorkgroupPermission(nIdForm, request);
-
         if ( nIdStep != -1 )
         {
             _step = StepHome.findByPrimaryKey( nIdStep );
 
             if ( _step != null )
             {
                 nIdForm = _step.getIdForm( );
+                checkUserPermission( Form.RESOURCE_TYPE, String.valueOf( nIdForm ), FormsResourceIdService.PERMISSION_MODIFY, request, ACTION_CREATE_STEP );
+                checkWorkgroupPermission(nIdForm, request);
 
                 try
                 {

Original file line number	Diff line number	Diff line change
`@@ -379,16 +379,15 @@ public String doDuplicateStep( HttpServletRequest request ) throws AccessDeniedE`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`int nIdForm = -1;`
`382`		`- checkUserPermission( Form.RESOURCE_TYPE, String.valueOf( nIdForm ), FormsResourceIdService.PERMISSION_MODIFY, request, ACTION_CREATE_STEP );`
`383`		`- checkWorkgroupPermission(nIdForm, request);`
`384`		`-`
`385`	`382`	`if ( nIdStep != -1 )`
`386`	`383`	`{`
`387`	`384`	`_step = StepHome.findByPrimaryKey( nIdStep );`
`388`	`385`
`389`	`386`	`if ( _step != null )`
`390`	`387`	`{`
`391`	`388`	`nIdForm = _step.getIdForm( );`
	`389`	`+ checkUserPermission( Form.RESOURCE_TYPE, String.valueOf( nIdForm ), FormsResourceIdService.PERMISSION_MODIFY, request, ACTION_CREATE_STEP );`
	`390`	`+ checkWorkgroupPermission(nIdForm, request);`
`392`	`391`
`393`	`392`	`try`
`394`	`393`	`{`