How to cancel a command?

[shivamdev-lgtm]

How do we cancel downloads after a download has started? I am trying something like this but it doesn't get cancelled when the context is cancelled after 5 seconds:

package main

import (
	"context"
	"time"

	"github.com/lrstanley/go-ytdlp"
)

func main() {
	ctx, _ := context.WithTimeout(context.Background(), 5*time.Second)

	dl := ytdlp.New().
		FormatSort("res,ext:mp4:m4a").
		RecodeVideo("mp4").
		Output("%(extractor)s - %(title)s.%(ext)s")

	_, err := dl.Run(ctx, "https://www.youtube.com/watch?v=dQw4w9WgXcQ")
	if err != nil {
		panic(err)
	}
}

I can see the entire file getting downloaded in my filesystem and then only it stops blocking

[shivamdev-lgtm]

cc: @lrstanley

[lrstanley]

It's possible that the way exec.CommandContext() works, that it only attempts to kill the main child process, not child processes of yt-dlp (e.g. ffmpeg), in which it will keep running until it's complete, though I'd still think ffmpeg would fail nearly immediately. I haven't had the chance to try and replicate yet, but will let you know and see if I can look into a fix. Ideally, it should definitely get killed and return immediately.

[lrstanley]

This is fixed in v1.2.6.