Fixing jest tests.

Author: lrnselfreliance

app/src/hooks/useForm.js

@@ -113,10 +113,12 @@ export function useForm({
                 reset();
             }
             await onSuccess();
+        } catch (error) {
+            await onFailure(error);
+            throw error;
         } finally {
             setLoading(false);
             setDisabled(false);
-            await onFailure();
         }
     }
 

app/src/hooks/useForm.test.js

@@ -183,9 +183,7 @@ describe('useForm', () => {
             expect(onSuccess).toHaveBeenCalled();
         });
 
-        it('always calls onFailure in finally block (current behavior)', async () => {
-            // NOTE: This documents current behavior where onFailure is called even on success
-            // This may be a bug or intentional cleanup callback - kept for regression safety
+        it('does not call onFailure on successful submit', async () => {
             const onSuccess = jest.fn();
             const onFailure = jest.fn();
             const submitter = jest.fn().mockResolvedValue(undefined);
@@ -202,7 +200,7 @@ describe('useForm', () => {
             });
 
             expect(onSuccess).toHaveBeenCalled();
-            expect(onFailure).toHaveBeenCalled(); // Called even on success
+            expect(onFailure).not.toHaveBeenCalled();
         });
 
         it('clears form when clearOnSuccess is true', async () => {