Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Commit 0abdea6

Browse files
authored
feat: upgrade faraday dependency (#108)
- new interface for middleware -- https://lostisland.github.io/faraday/middleware/custom - as of version 0.1.0, ruby 2.5 is the oldest version we support
1 parent 58f3947 commit 0abdea6

File tree

5 files changed

+8
-24
lines changed

5 files changed

+8
-24
lines changed

Makefile

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,8 @@
3131
# Automatic variables: http://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_10.html#SEC101
3232

3333
# Rbenv-friendly version identifiers for supported Rubys
34-
20_version = 2.0.0-p648
35-
21_version = 2.1.10
36-
23_version = 2.3.1
37-
jruby_9150_version = jruby-9.1.5.0
34+
25_version = 2.5.7
35+
jruby_92160_version = jruby-9.2.16.0
3836

3937
# The ruby version for use in a given rule.
4038
# Requires a matched pattern rule and a supported ruby version.
@@ -54,7 +52,7 @@ given_ruby_version = $($(addsuffix _version, $*))
5452
with_given_ruby = RBENV_VERSION=$(given_ruby_version)
5553

5654
# Runs tests for all supported ruby versions.
57-
test: test-20 test-21 test-23 test-jruby_9150
55+
test: test-25 test-jruby_92160
5856

5957
# Runs tests against a specific ruby version
6058
test-%:
@@ -63,7 +61,7 @@ test-%:
6361
$(with_given_ruby) rake
6462

6563
# Installs all ruby versions and their gems
66-
install: install-20 install-21 install-23 install-jruby_9150
64+
install: install-25 install-jruby_92160
6765

6866
# Install a particular ruby version
6967
install-ruby-%:
@@ -77,17 +75,6 @@ install-gems-%:
7775
$(with_given_ruby) gem install bundler
7876
$(with_given_ruby) bundle install
7977

80-
# special case 20 and 21 need older bundler
81-
install-gems-20:
82-
rm -f Gemfile.lock
83-
RBENV_VERSION=$(20_version) gem install bundler -v '~>1'
84-
RBENV_VERSION=$(20_version) bundle install
85-
86-
install-gems-21:
87-
rm -f Gemfile.lock
88-
RBENV_VERSION=$(21_version) gem install bundler -v '~>1'
89-
RBENV_VERSION=$(21_version) bundle install
90-
9178
# Installs a specific ruby version and it's gems
9279
# At the bottom so it doesn't match install-gems and install-ruby tasks.
9380
install-%:

lib/looker-sdk.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
require 'faraday/request'
4444
require 'faraday/request/authorization'
4545
require 'faraday/response'
46-
require 'faraday/upload_io'
4746
require 'faraday/utils'
4847

4948
#require 'rack'

lib/looker-sdk/response/raise_error.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ module LookerSDK
3030
module Response
3131

3232
# HTTP status codes returned by the API
33-
class RaiseError < Faraday::Response::Middleware
34-
35-
private
33+
class RaiseError < Faraday::Middleware
3634

3735
def on_complete(response)
3836
if error = LookerSDK::Error.from_response(response)

lib/looker-sdk/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ module LookerSDK
2626

2727
# Current version
2828
# @return [String]
29-
VERSION = "0.0.8"
29+
VERSION = "0.1.0"
3030

3131
end

looker-sdk.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
1515
'the Looker data analytics engine to fetch data or render visualizations defined in your Looker data models. '+
1616
'For more information, see https://looker.com.'
1717
s.license = 'MIT'
18-
s.required_ruby_version = '>= 2.0'
18+
s.required_ruby_version = '>= 2.5'
1919
s.requirements = 'Looker version 4.0 or later' # informational
2020

2121
s.files = `git ls-files`.split("\n")
@@ -24,5 +24,5 @@ Gem::Specification.new do |s|
2424
s.require_paths = %w(lib)
2525
s.add_dependency 'jruby-openssl' if s.platform == :jruby
2626
s.add_dependency 'sawyer', '~> 0.8'
27-
s.add_dependency 'faraday', ['>= 0.9.0', '< 1.0']
27+
s.add_dependency 'faraday', ['>= 1.0', '< 2.0']
2828
end

0 commit comments

Comments
 (0)