Skip to content

Commit 90db37d

Browse files
committed
log consumer opens, closes, and exceptions
1 parent 0a77b6a commit 90db37d

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

lib/logstash/inputs/kafka.rb

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,12 @@ def register
221221

222222
public
223223
def run(logstash_queue)
224-
@runner_consumers = consumer_threads.times.map { |i| create_consumer("#{client_id}-#{i}") }
225-
@runner_threads = @runner_consumers.map { |consumer| thread_runner(logstash_queue, consumer) }
224+
@runner_consumers = consumer_threads.times.map do |index|
225+
create_consumer("#{client_id}-#{index}")
226+
end
227+
@runner_threads = @runner_consumers.map.with_index do |consumer, index|
228+
thread_runner(logstash_queue, consumer, index)
229+
end
226230
@runner_threads.each { |t| t.join }
227231
end # def run
228232

@@ -237,9 +241,11 @@ def kafka_consumers
237241
end
238242

239243
private
240-
def thread_runner(logstash_queue, consumer)
244+
def thread_runner(logstash_queue, consumer, consumer_index)
245+
consumer_identifier = "#{client_id}-#{consumer_index}"
241246
Thread.new do
242247
begin
248+
logger.info("opening consumer #{consumer_identifier}")
243249
unless @topics_pattern.nil?
244250
nooplistener = org.apache.kafka.clients.consumer.internals.NoOpConsumerRebalanceListener.new
245251
pattern = java.util.regex.Pattern.compile(@topics_pattern)
@@ -271,8 +277,15 @@ def thread_runner(logstash_queue, consumer)
271277
end
272278
end
273279
rescue org.apache.kafka.common.errors.WakeupException => e
274-
raise e if !stop?
280+
unless stop?
281+
logger.error("wakeup exception in consumer #{consumer_identifier}: #{e}")
282+
raise e
283+
end
284+
rescue => e
285+
logger.error("uncaught exception in consumer #{consumer_identifier}: #{e}")
286+
raise e
275287
ensure
288+
logger.info("closing consumer #{consumer_identifier}")
276289
consumer.close
277290
end
278291
end

0 commit comments

Comments
 (0)