Docs/fix readme inaccuracies#37
Conversation
All 5 MockPooldoseClient constructor examples were missing the required model_id and fw_code parameters, causing TypeError at runtime.
Mapping JSON is loaded right after Debug Config, before WiFi/AP/Network info. The diagram incorrectly showed it as the last step.
Replace abbreviated names (get_debug, get_wifi, get_values) with the real RequestHandler method names and add missing endpoints (get_access_point, get_network_info, get_device_language).
Add missing parameters: websession, debug_payload, retry_delay. Add keyword-only marker (*) to match actual signature.
These convenience methods on PooldoseClient were shown in the Program Flow diagram but missing from the API Reference methods listing.
- Translate German comment to English (Beispiel mit Fantasiewerten) - Document --version flag in CLI usage sections - Add note about --host/--mock mutual exclusivity - Add note that --analyze requires --host - Fix VA DOS EXACT alias reference: PDHC1H1HAR1V0 -> PDPR1H1HAR1V0
|
Thanks for this update, I was thinking about to shrink the whole readme. Since you are the first contributor, you can judge on this. Is the document overloaded or helpful in that form? |
|
The README has grown quite long (~900 lines), which makes it hard to navigate. What do you think about splitting the detailed sections into a Proposed approach:
Why
I'll prepare a draft-PR |
|
I like, thanks for honest feedback. This changelog summary we also do not need in the readme. Just a reference to the changelog is sufficient. However, I think the wiki is made for such details for ease navigation. I need to think about... You did so much already for this project. If you like, please continue, otherwise I take the part on the remaining tasks. Decide on your own please. |
|
See #38 |
|
Thanks! Happy to continue. On wiki vs
That said, wiki is great for community content (FAQ, troubleshooting) that doesn't need to track code versions. |
|
May we start like this. I saw some actions to auto-update the wiki from a bunch of md files. However, we do need this right now. Let's follow you approach... |
PR is ready |
|
Ok but this one here is outdated? |
|
yes, this one can be closed. Moved all the changes to the other PR |
Fix README inaccuracies
Fixes multiple documentation issues found during a README review.
MockPooldoseClient examples (commit 996b272)
All 5
MockPooldoseClientconstructor examples were missing the requiredmodel_idandfw_codeparameters, which would cause crashes when copy-pasted.Program Flow diagram (commit 7a53c7a)
The diagram showed mapping JSON loading as the last step of
connect(). In the actual code, it happens as the second step (right after fetching debug config), before WiFi/AP/network info.API Architecture diagram (commit 749e74e)
getInstantValues>get_values_raw,getDebugConfig→get_debug_config)get_device_language,set_valueConstructor API Reference (commit 9cdb79a)
websession,debug_payload,retry_delay*) in signatureMethods API Reference (commit 479ae59)
Missing methods:
set_switch(),set_number(),set_select()CLI docs, German comment, alias table (commit 780fe53)
"Beispiel mit Fantasiewerten"to English--versionflag in both CLI usage sections--host/--mockmutaul exclusivity--analyze/--analyze-allrequire--host