Skip to content

Commit a82b390

Browse files
committed
Respond to reviewer comments re: in-line code comments
1 parent e29429e commit a82b390

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5066,10 +5066,11 @@ SDValue AMDGPUTargetLowering::performFNegCombine(SDNode *N,
50665066
}
50675067
case ISD::SELECT: {
50685068
// fneg (select c, a, b) -> select c, (fneg a), (fneg b)
5069-
// This combine became necessary recently to prevent a regression caused by
5070-
// this patch legalising v2i32 xor. When adding this combine a case was
5071-
// added to performFNEGCombine to prevent this combine from being undone
5072-
// under certain conditions.
5069+
// This combine became necessary recently to prevent a regression in
5070+
// fneg-modifier-casting.ll caused by this patch legalising v2i32 xor.
5071+
// Specifically, additional instructions were added to the final codegen.
5072+
// When adding this combine a case was added to performFNEGCombine to
5073+
// prevent this combine from being undone under certain conditions.
50735074
// TODO: Invert conditions of foldFreeOpFromSelect
50745075
SDValue Cond = N0.getOperand(0);
50755076
SDValue LHS = N0.getOperand(1);

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5938,7 +5938,8 @@ SDValue SITargetLowering::splitUnaryVectorOp(SDValue Op,
59385938
}
59395939

59405940
// Enable lowering of ROTR for vxi32 types. This is a workaround for a
5941-
// regression caused by legalising v2i32 or.
5941+
// regression in rotr.ll, whereby extra unnecessary instructions were added to
5942+
// the final codegen caused by legalising v2i32 or.
59425943
SDValue SITargetLowering::lowerROTR(SDValue Op, SelectionDAG &DAG) const {
59435944
[[maybe_unused]] EVT VT = Op.getValueType();
59445945

0 commit comments

Comments
 (0)