Skip to content

Commit 416ae92

Browse files
committed
adjust comment
1 parent de8e1cb commit 416ae92

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

llvm/test/Analysis/Delinearization/validation_large_size.ll

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 6
22
; RUN: opt < %s -passes='print<delinearization>' --delinearize-use-fixed-size-array-heuristic -disable-output 2>&1 | FileCheck %s
33

4-
; FIXME: When considering an array as a function from subcripts to addresses,
5-
; it should be injective. That is, different subscript tuples should map to
6-
; different addresses. Currently, delinearization doesn't guarantee this
7-
; property, especially when the inferred array size is very large so that the
8-
; product of dimensions may overflow. The delinearization validation should
9-
; consider such cases as invalid.
4+
; FIXME: As for array accesses, the following property should hold (without
5+
; out-of-bound accesses):
6+
;
7+
; &A[I_1][I_2]...[I_n] == &A[J_1][J_2]...[J_n] iff
8+
; (I_1, I_2, ..., I_n) == (J_1, J_2, ..., J_n)
9+
;
10+
; Currently, delinearization doesn't guarantee this property, especially when
11+
; the inferred array size is very large so that the product of dimensions may
12+
; overflow. The delinearization validation should consider such cases as
13+
; invalid.
1014

1115
; for (i = 0; i < (1ULL << 60); i++)
1216
; for (j = 0; j < 256; j++)

0 commit comments

Comments
 (0)