Skip to content

Commit 3e1889a

Browse files
committed
AMDGPU: Add baseline test for mfma rewrite with phi
The first case currently works as expected, but defends against a regression I nearly introduced in a later patch. The loop case does not work as expected yet.
1 parent 6f0530c commit 3e1889a

File tree

1 file changed

+181
-0
lines changed

1 file changed

+181
-0
lines changed
Lines changed: 181 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,181 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
2+
; RUN: llc -mcpu=gfx942 -amdgpu-mfma-vgpr-form < %s | FileCheck %s
3+
4+
target triple = "amdgcn-amd-amdhsa"
5+
6+
define amdgpu_kernel void @test_rewrite_mfma_copy_to_agpr_phi(ptr addrspace(1) %arg0, ptr addrspace(1) %arg1, i1 %cond) #0 {
7+
; CHECK-LABEL: test_rewrite_mfma_copy_to_agpr_phi:
8+
; CHECK: ; %bb.0: ; %bb
9+
; CHECK-NEXT: s_load_dword s6, s[4:5], 0x10
10+
; CHECK-NEXT: s_load_dwordx4 s[0:3], s[4:5], 0x0
11+
; CHECK-NEXT: v_and_b32_e32 v0, 0x3ff, v0
12+
; CHECK-NEXT: v_lshlrev_b32_e32 v32, 7, v0
13+
; CHECK-NEXT: s_waitcnt lgkmcnt(0)
14+
; CHECK-NEXT: s_bitcmp0_b32 s6, 0
15+
; CHECK-NEXT: s_cbranch_scc0 .LBB0_2
16+
; CHECK-NEXT: ; %bb.1: ; %else
17+
; CHECK-NEXT: global_load_dwordx4 a[28:31], v32, s[2:3] offset:112
18+
; CHECK-NEXT: global_load_dwordx4 a[24:27], v32, s[2:3] offset:96
19+
; CHECK-NEXT: global_load_dwordx4 a[20:23], v32, s[2:3] offset:80
20+
; CHECK-NEXT: global_load_dwordx4 a[16:19], v32, s[2:3] offset:64
21+
; CHECK-NEXT: global_load_dwordx4 a[12:15], v32, s[2:3] offset:48
22+
; CHECK-NEXT: global_load_dwordx4 a[8:11], v32, s[2:3] offset:32
23+
; CHECK-NEXT: global_load_dwordx4 a[4:7], v32, s[2:3] offset:16
24+
; CHECK-NEXT: global_load_dwordx4 a[0:3], v32, s[2:3]
25+
; CHECK-NEXT: v_mov_b32_e32 v33, 2.0
26+
; CHECK-NEXT: v_mov_b32_e32 v34, 4.0
27+
; CHECK-NEXT: s_waitcnt vmcnt(0)
28+
; CHECK-NEXT: s_nop 0
29+
; CHECK-NEXT: v_mfma_f32_32x32x1_2b_f32 a[0:31], v33, v34, a[0:31]
30+
; CHECK-NEXT: ; kill: def $agpr0_agpr1_agpr2_agpr3_agpr4_agpr5_agpr6_agpr7_agpr8_agpr9_agpr10_agpr11_agpr12_agpr13_agpr14_agpr15_agpr16_agpr17_agpr18_agpr19_agpr20_agpr21_agpr22_agpr23_agpr24_agpr25_agpr26_agpr27_agpr28_agpr29_agpr30_agpr31 killed $agpr0_agpr1_agpr2_agpr3_agpr4_agpr5_agpr6_agpr7_agpr8_agpr9_agpr10_agpr11_agpr12_agpr13_agpr14_agpr15_agpr16_agpr17_agpr18_agpr19_agpr20_agpr21_agpr22_agpr23_agpr24_agpr25_agpr26_agpr27_agpr28_agpr29_agpr30_agpr31 killed $exec
31+
; CHECK-NEXT: s_cbranch_execz .LBB0_3
32+
; CHECK-NEXT: s_branch .LBB0_4
33+
; CHECK-NEXT: .LBB0_2:
34+
; CHECK-NEXT: ; implicit-def: $agpr0_agpr1_agpr2_agpr3_agpr4_agpr5_agpr6_agpr7_agpr8_agpr9_agpr10_agpr11_agpr12_agpr13_agpr14_agpr15_agpr16_agpr17_agpr18_agpr19_agpr20_agpr21_agpr22_agpr23_agpr24_agpr25_agpr26_agpr27_agpr28_agpr29_agpr30_agpr31
35+
; CHECK-NEXT: .LBB0_3: ; %if
36+
; CHECK-NEXT: s_nop 7
37+
; CHECK-NEXT: s_nop 7
38+
; CHECK-NEXT: global_load_dwordx4 a[28:31], v32, s[0:1] offset:112
39+
; CHECK-NEXT: global_load_dwordx4 a[24:27], v32, s[0:1] offset:96
40+
; CHECK-NEXT: global_load_dwordx4 a[20:23], v32, s[0:1] offset:80
41+
; CHECK-NEXT: global_load_dwordx4 a[16:19], v32, s[0:1] offset:64
42+
; CHECK-NEXT: global_load_dwordx4 a[12:15], v32, s[0:1] offset:48
43+
; CHECK-NEXT: global_load_dwordx4 a[8:11], v32, s[0:1] offset:32
44+
; CHECK-NEXT: global_load_dwordx4 a[4:7], v32, s[0:1] offset:16
45+
; CHECK-NEXT: global_load_dwordx4 a[0:3], v32, s[0:1]
46+
; CHECK-NEXT: v_mov_b32_e32 v32, 2.0
47+
; CHECK-NEXT: v_mov_b32_e32 v33, 4.0
48+
; CHECK-NEXT: s_waitcnt vmcnt(0)
49+
; CHECK-NEXT: s_nop 0
50+
; CHECK-NEXT: v_mfma_f32_32x32x1_2b_f32 a[0:31], v32, v33, a[0:31]
51+
; CHECK-NEXT: ; kill: def $agpr0_agpr1_agpr2_agpr3_agpr4_agpr5_agpr6_agpr7_agpr8_agpr9_agpr10_agpr11_agpr12_agpr13_agpr14_agpr15_agpr16_agpr17_agpr18_agpr19_agpr20_agpr21_agpr22_agpr23_agpr24_agpr25_agpr26_agpr27_agpr28_agpr29_agpr30_agpr31 killed $agpr0_agpr1_agpr2_agpr3_agpr4_agpr5_agpr6_agpr7_agpr8_agpr9_agpr10_agpr11_agpr12_agpr13_agpr14_agpr15_agpr16_agpr17_agpr18_agpr19_agpr20_agpr21_agpr22_agpr23_agpr24_agpr25_agpr26_agpr27_agpr28_agpr29_agpr30_agpr31 killed $exec
52+
; CHECK-NEXT: .LBB0_4: ; %endif
53+
; CHECK-NEXT: ;;#ASMSTART
54+
; CHECK-NEXT: ; use a[0:31]
55+
; CHECK-NEXT: ;;#ASMEND
56+
; CHECK-NEXT: s_endpgm
57+
bb:
58+
%id = call i32 @llvm.amdgcn.workitem.id.x()
59+
br i1 %cond, label %if, label %else
60+
61+
if:
62+
%gep.0 = getelementptr <32 x float>, ptr addrspace(1) %arg0, i32 %id
63+
%in.0 = load <32 x float>, ptr addrspace(1) %gep.0, align 128
64+
%mai.0 = call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float 2.0, float 4.0, <32 x float> %in.0, i32 0, i32 0, i32 0)
65+
br label %endif
66+
67+
else:
68+
%gep.1 = getelementptr <32 x float>, ptr addrspace(1) %arg1, i32 %id
69+
%in.1 = load <32 x float>, ptr addrspace(1) %gep.1, align 128
70+
%mai.1 = call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float 2.0, float 4.0, <32 x float> %in.1, i32 0, i32 0, i32 0)
71+
br label %endif
72+
73+
endif:
74+
%phi = phi <32 x float> [ %mai.0, %if ], [ %mai.1, %else ]
75+
call void asm sideeffect "; use $0", "a"(<32 x float> %phi)
76+
ret void
77+
}
78+
79+
define amdgpu_kernel void @test_rewrite_mfma_copy_to_agpr_phi_loop(ptr addrspace(1) %arg0, ptr addrspace(1) %arg1, i32 %n) #0 {
80+
; CHECK-LABEL: test_rewrite_mfma_copy_to_agpr_phi_loop:
81+
; CHECK: ; %bb.0: ; %entry
82+
; CHECK-NEXT: s_load_dwordx2 s[2:3], s[4:5], 0x0
83+
; CHECK-NEXT: s_load_dword s0, s[4:5], 0x10
84+
; CHECK-NEXT: v_and_b32_e32 v0, 0x3ff, v0
85+
; CHECK-NEXT: v_lshlrev_b32_e32 v32, 7, v0
86+
; CHECK-NEXT: s_mov_b32 s1, 0
87+
; CHECK-NEXT: s_waitcnt lgkmcnt(0)
88+
; CHECK-NEXT: global_load_dwordx4 v[28:31], v32, s[2:3] offset:112
89+
; CHECK-NEXT: global_load_dwordx4 v[24:27], v32, s[2:3] offset:96
90+
; CHECK-NEXT: global_load_dwordx4 v[20:23], v32, s[2:3] offset:80
91+
; CHECK-NEXT: global_load_dwordx4 v[16:19], v32, s[2:3] offset:64
92+
; CHECK-NEXT: global_load_dwordx4 v[12:15], v32, s[2:3] offset:48
93+
; CHECK-NEXT: global_load_dwordx4 v[8:11], v32, s[2:3] offset:32
94+
; CHECK-NEXT: global_load_dwordx4 v[4:7], v32, s[2:3] offset:16
95+
; CHECK-NEXT: global_load_dwordx4 v[0:3], v32, s[2:3]
96+
; CHECK-NEXT: v_mov_b32_e32 v64, 4.0
97+
; CHECK-NEXT: v_mov_b32_e32 v65, 2.0
98+
; CHECK-NEXT: .LBB1_1: ; %loop
99+
; CHECK-NEXT: ; =>This Inner Loop Header: Depth=1
100+
; CHECK-NEXT: s_waitcnt vmcnt(0)
101+
; CHECK-NEXT: s_nop 7
102+
; CHECK-NEXT: s_nop 7
103+
; CHECK-NEXT: v_mov_b64_e32 v[62:63], v[30:31]
104+
; CHECK-NEXT: v_mov_b64_e32 v[60:61], v[28:29]
105+
; CHECK-NEXT: v_mov_b64_e32 v[58:59], v[26:27]
106+
; CHECK-NEXT: v_mov_b64_e32 v[56:57], v[24:25]
107+
; CHECK-NEXT: v_mov_b64_e32 v[54:55], v[22:23]
108+
; CHECK-NEXT: v_mov_b64_e32 v[52:53], v[20:21]
109+
; CHECK-NEXT: v_mov_b64_e32 v[50:51], v[18:19]
110+
; CHECK-NEXT: v_mov_b64_e32 v[48:49], v[16:17]
111+
; CHECK-NEXT: v_mov_b64_e32 v[46:47], v[14:15]
112+
; CHECK-NEXT: v_mov_b64_e32 v[44:45], v[12:13]
113+
; CHECK-NEXT: v_mov_b64_e32 v[42:43], v[10:11]
114+
; CHECK-NEXT: v_mov_b64_e32 v[40:41], v[8:9]
115+
; CHECK-NEXT: v_mov_b64_e32 v[38:39], v[6:7]
116+
; CHECK-NEXT: v_mov_b64_e32 v[36:37], v[4:5]
117+
; CHECK-NEXT: v_mov_b64_e32 v[34:35], v[2:3]
118+
; CHECK-NEXT: v_mov_b64_e32 v[32:33], v[0:1]
119+
; CHECK-NEXT: s_add_i32 s1, s1, 1
120+
; CHECK-NEXT: s_cmp_lt_u32 s1, s0
121+
; CHECK-NEXT: v_mfma_f32_32x32x1_2b_f32 v[0:31], v65, v64, v[32:63]
122+
; CHECK-NEXT: v_mfma_f32_32x32x1_2b_f32 v[0:31], v65, v64, v[0:31]
123+
; CHECK-NEXT: s_cbranch_scc1 .LBB1_1
124+
; CHECK-NEXT: ; %bb.2: ; %endif
125+
; CHECK-NEXT: v_accvgpr_write_b32 a0, v32
126+
; CHECK-NEXT: v_accvgpr_write_b32 a1, v33
127+
; CHECK-NEXT: v_accvgpr_write_b32 a2, v34
128+
; CHECK-NEXT: v_accvgpr_write_b32 a3, v35
129+
; CHECK-NEXT: v_accvgpr_write_b32 a4, v36
130+
; CHECK-NEXT: v_accvgpr_write_b32 a5, v37
131+
; CHECK-NEXT: v_accvgpr_write_b32 a6, v38
132+
; CHECK-NEXT: v_accvgpr_write_b32 a7, v39
133+
; CHECK-NEXT: v_accvgpr_write_b32 a8, v40
134+
; CHECK-NEXT: v_accvgpr_write_b32 a9, v41
135+
; CHECK-NEXT: v_accvgpr_write_b32 a10, v42
136+
; CHECK-NEXT: v_accvgpr_write_b32 a11, v43
137+
; CHECK-NEXT: v_accvgpr_write_b32 a12, v44
138+
; CHECK-NEXT: v_accvgpr_write_b32 a13, v45
139+
; CHECK-NEXT: v_accvgpr_write_b32 a14, v46
140+
; CHECK-NEXT: v_accvgpr_write_b32 a15, v47
141+
; CHECK-NEXT: v_accvgpr_write_b32 a16, v48
142+
; CHECK-NEXT: v_accvgpr_write_b32 a17, v49
143+
; CHECK-NEXT: v_accvgpr_write_b32 a18, v50
144+
; CHECK-NEXT: v_accvgpr_write_b32 a19, v51
145+
; CHECK-NEXT: v_accvgpr_write_b32 a20, v52
146+
; CHECK-NEXT: v_accvgpr_write_b32 a21, v53
147+
; CHECK-NEXT: v_accvgpr_write_b32 a22, v54
148+
; CHECK-NEXT: v_accvgpr_write_b32 a23, v55
149+
; CHECK-NEXT: v_accvgpr_write_b32 a24, v56
150+
; CHECK-NEXT: v_accvgpr_write_b32 a25, v57
151+
; CHECK-NEXT: v_accvgpr_write_b32 a26, v58
152+
; CHECK-NEXT: v_accvgpr_write_b32 a27, v59
153+
; CHECK-NEXT: v_accvgpr_write_b32 a28, v60
154+
; CHECK-NEXT: v_accvgpr_write_b32 a29, v61
155+
; CHECK-NEXT: v_accvgpr_write_b32 a30, v62
156+
; CHECK-NEXT: v_accvgpr_write_b32 a31, v63
157+
; CHECK-NEXT: ;;#ASMSTART
158+
; CHECK-NEXT: ; use a[0:31]
159+
; CHECK-NEXT: ;;#ASMEND
160+
; CHECK-NEXT: s_endpgm
161+
entry:
162+
%id = call i32 @llvm.amdgcn.workitem.id.x()
163+
%gep.0 = getelementptr <32 x float>, ptr addrspace(1) %arg0, i32 %id
164+
%in.0 = load <32 x float>, ptr addrspace(1) %gep.0, align 128
165+
br label %loop
166+
167+
loop:
168+
%i.phi = phi i32 [ 0, %entry ], [ %i.inc, %loop ]
169+
%phi = phi <32 x float> [ %in.0, %entry ], [ %mai.1, %loop ]
170+
%mai.0 = call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float 2.0, float 4.0, <32 x float> %phi, i32 0, i32 0, i32 0)
171+
%mai.1 = call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float 2.0, float 4.0, <32 x float> %mai.0, i32 0, i32 0, i32 0)
172+
%i.inc = add i32 %i.phi, 1
173+
%loop.cond = icmp ult i32 %i.inc, %n
174+
br i1 %loop.cond, label %loop, label %endif
175+
176+
endif:
177+
call void asm sideeffect "; use $0", "a"(<32 x float> %phi)
178+
ret void
179+
}
180+
181+
attributes #0 = { nounwind "amdgpu-flat-work-group-size"="1,256" "amdgpu-waves-per-eu"="1,1" }

0 commit comments

Comments
 (0)