chore: unpin forge and remove unused solarray dependency (#362)

**Motivation:**

In #304 we pinned forge to the
most recent nightly at the time, due to breaking changes that were
introduced. I believe the specific breaking changes that affected us
were reverted upstream on master in favor of the `expect-changes`
feature branch which will hold forge breaking changes until v1, as all
tests in the llama

Also removes unused solarray dependency

**Modifications:**

Unpin the forge version and remove unused dependency

**Result:**

Unpin the forge version and remove unused dependency

Author: mds1

.github/workflows/ci.yml

@@ -19,8 +19,6 @@ jobs:
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
-        with:
-          version: nightly-e15e33a07c0920189fc336391f538c3dad53da73
 
       - name: Build contracts
         run: |
@@ -35,8 +33,6 @@ jobs:
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
-        with:
-          version: nightly-e15e33a07c0920189fc336391f538c3dad53da73
 
       - name: Run tests
         run: forge test -vvv
@@ -49,8 +45,6 @@ jobs:
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
-        with:
-          version: nightly-e15e33a07c0920189fc336391f538c3dad53da73
 
       - name: Run coverage
         run: forge coverage --report summary --report lcov
@@ -94,8 +88,6 @@ jobs:
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
-        with:
-          version: nightly-e15e33a07c0920189fc336391f538c3dad53da73
 
       - name: Check formatting
         run: forge fmt --check
@@ -108,8 +100,6 @@ jobs:
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
-        with:
-          version: nightly-e15e33a07c0920189fc336391f538c3dad53da73
 
       - name: Install scopelint
         uses: engineerd/[email protected]

.gitmodules

@@ -14,7 +14,3 @@
 	path = lib/solady
 	url = https://github.com/vectorized/solady
 	commit = 3d57528984275d1746ee6597acd36277f51c091d
-[submodule "lib/solarray"]
-	path = lib/solarray
-	url = https://github.com/emo-eth/solarray
-	commit = 4c3b8ff8e90c8cd11d30e02c1b6b2fcf9bc0f3db

lib/solarray

@@ -1,4 +1,3 @@
 @openzeppelin=lib/openzeppelin-contracts/contracts/
 @solmate=lib/solmate/src/
-@solady=lib/solady/src/
-@solarray=lib/solarray/src/
+@solady=lib/solady/src/

remappings.txt

@@ -3,8 +3,6 @@ pragma solidity ^0.8.19;
 
 import {Test, console2, StdStorage, stdStorage} from "forge-std/Test.sol";
 
-import {Solarray} from "@solarray/Solarray.sol";
-
 import {MockAccountLogicContract} from "test/mock/MockAccountLogicContract.sol";
 import {MockActionGuard} from "test/mock/MockActionGuard.sol";
 import {MockMaliciousExtension} from "test/mock/MockMaliciousExtension.sol";

test/LlamaCore.t.sol

@@ -3,8 +3,6 @@ pragma solidity ^0.8.19;
 
 import {Test, console2} from "forge-std/Test.sol";
 
-import {Solarray} from "@solarray/Solarray.sol";
-
 import {SolarrayLlama} from "test/utils/SolarrayLlama.sol";
 import {LlamaTestSetup} from "test/utils/LlamaTestSetup.sol";
 

test/LlamaFactory.t.sol

@@ -7,8 +7,6 @@ import {Base64} from "@openzeppelin/utils/Base64.sol";
 
 import {Clones} from "@openzeppelin/proxy/Clones.sol";
 
-import {Solarray} from "@solarray/Solarray.sol";
-
 import {LibString} from "@solady/utils/LibString.sol";
 
 import {Roles, LlamaTestSetup} from "test/utils/LlamaTestSetup.sol";

test/LlamaPolicy.t.sol

@@ -3,8 +3,6 @@ pragma solidity ^0.8.19;
 
 import {Test, console2} from "forge-std/Test.sol";
 
-import {Solarray} from "@solarray/Solarray.sol";
-
 import {MockActionGuard} from "test/mock/MockActionGuard.sol";
 import {MockMaliciousExtension} from "test/mock/MockMaliciousExtension.sol";
 import {MockProtocol} from "test/mock/MockProtocol.sol";

test/llama-scripts/LlamaGovernanceScript.t.sol

@@ -7,8 +7,6 @@ import {stdJson} from "forge-std/Script.sol";
 
 import {IERC20} from "@openzeppelin/token/ERC20/IERC20.sol";
 
-import {Solarray} from "@solarray/Solarray.sol";
-
 import {MockProtocol} from "test/mock/MockProtocol.sol";
 import {MockScript} from "test/mock/MockScript.sol";