nvme: add --block-size option to IO interface to bypass identify command
#2920
+72
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateThornton
force-pushed
the
io_no_ident
branch
from
c88f924 to
ff532ab
Compare
NateThornton
changed the title
--block-size option to IO interface to bypass identify command
…nds. When specified, the --block-size is used as the logical block size in bytes, and the --metadata-size is used as the metadata size in bytes. Signed-off-by: Nate Thornton <[email protected]>
…y commands. Adds `--block-size=` and `-b` to various completions Signed-off-by: Nate Thornton <[email protected]>
NateThornton
force-pushed
the
io_no_ident
branch
from
ff532ab to
8f043c5
Compare
Collaborator
|
Could also update the documentation please? |
Include new `--block-size=` in compare/read/write documentation Signed-off-by: Nate Thornton <[email protected]>
NateThornton
force-pushed
the
io_no_ident
branch
from
05e88b8 to
b4fb8fc
Compare
Collaborator
|
Thanks! |
Collaborator
|
Right after merging I saw the the nvme-write documentation had an typo for the short-hand. Fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is desired to only issue the underlying I/O command through submit_io (compare, read, write). Currently, at least one identify namespace is used to discover the logical block size.
This change adds a new
--block-size=option to the submit_io interface. When provided, the--block-size=is used as the logical block size in bytes, and the--metadata-size=is also used as the metadata size in bytes. Storage and Reference tag checks are bypassed.(I am less certain about the
--metadata-size=acting per-block, and how best to support or document it. One idea would be to take the metadata-size as a the total size across all blocks, and settingms = cfg.metadata_size / (cfg.block_count + 1). I'm open to ideas or changes here)