Skip to content

Commit c4a1e11

Browse files
ikegami-tigaw
authored andcommitted
amzn: avoid sprinkling ifdefs and use flags
Use flags instead of cfg.output_format. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent ebbf498 commit c4a1e11

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

plugins/amzn/amzn-nvme.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@
1818
#define AMZN_NVME_STATS_LOGPAGE_ID 0xD0
1919
#define AMZN_NVME_STATS_MAGIC 0x3C23B510
2020

21-
#ifdef CONFIG_JSONC
2221
#define array_add_obj json_array_add_value_object
2322
#define obj_add_array json_object_add_value_array
2423
#define obj_add_obj json_object_add_value_object
2524
#define obj_add_uint json_object_add_value_uint
2625
#define obj_add_uint64 json_object_add_value_uint64
27-
#endif /* CONFIG_JSONC */
2826

2927
struct nvme_vu_id_ctrl_field {
3028
__u8 bdev[32];
@@ -169,6 +167,8 @@ static void amzn_print_json_stats(struct amzn_latency_log_page *log)
169167

170168
json_free_object(root);
171169
}
170+
#else /* CONFIG_JSONC */
171+
#define amzn_print_json_stats(log)
172172
#endif /* CONFIG_JSONC */
173173

174174
static void amzn_print_normal_stats(struct amzn_latency_log_page *log)
@@ -266,11 +266,9 @@ static int get_stats(int argc, char **argv, struct command *cmd,
266266
return err;
267267
}
268268

269-
#ifdef CONFIG_JSONC
270-
if (!strcmp(cfg.output_format, "json"))
269+
if (flags & JSON)
271270
amzn_print_json_stats(&log);
272271
else
273-
#endif /* CONFIG_JSONC */
274272
amzn_print_normal_stats(&log);
275273

276274
return 0;

0 commit comments

Comments
 (0)