Skip to content

Commit b31f133

Browse files
plugins/sandisk: Use Correct PCI Vendor ID for SNESSD1 Drives
The current Sandisk plugin code is using the Western Digital PCI vendor id for the SNESSD1 drives. It should be using the Sandisk Vendor ID (0x15B7) instead. The wdc plugin code also needs to be updated to recognize this new Sandisk device. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
1 parent 9ed7ba7 commit b31f133

File tree

3 files changed

+51
-20
lines changed

3 files changed

+51
-20
lines changed

plugins/sandisk/sandisk-nvme.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#if !defined(SANDISK_NVME) || defined(CMD_HEADER_MULTI_READ)
66
#define SANDISK_NVME
77

8-
#define SANDISK_PLUGIN_VERSION "3.0.7"
8+
#define SANDISK_PLUGIN_VERSION "3.0.8"
99
#include "cmd.h"
1010

1111
PLUGIN(NAME("sndk", "Sandisk vendor specific extensions", SANDISK_PLUGIN_VERSION),

plugins/sandisk/sandisk-utils.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -568,24 +568,6 @@ __u64 sndk_get_drive_capabilities(nvme_root_t r, struct nvme_dev *dev)
568568
SNDK_DRIVE_CAP_SET_LATENCY_MONITOR);
569569
break;
570570

571-
case SNDK_NVME_SNESSD1_DEV_ID_E1L:
572-
case SNDK_NVME_SNESSD1_DEV_ID_E2:
573-
case SNDK_NVME_SNESSD1_DEV_ID_E3S:
574-
case SNDK_NVME_SNESSD1_DEV_ID_E3L:
575-
case SNDK_NVME_SNESSD1_DEV_ID_U2:
576-
capabilities |= (SNDK_DRIVE_CAP_C0_LOG_PAGE |
577-
SNDK_DRIVE_CAP_C3_LOG_PAGE |
578-
SNDK_DRIVE_CAP_CA_LOG_PAGE |
579-
SNDK_DRIVE_CAP_OCP_C4_LOG_PAGE |
580-
SNDK_DRIVE_CAP_OCP_C5_LOG_PAGE |
581-
SNDK_DRIVE_CAP_UDUI |
582-
SNDK_DRIVE_CAP_VU_FID_CLEAR_PCIE |
583-
SNDK_DRIVE_CAP_CLOUD_SSD_VERSION |
584-
SNDK_DRIVE_CAP_LOG_PAGE_DIR |
585-
SNDK_DRIVE_CAP_DRIVE_STATUS |
586-
SNDK_DRIVE_CAP_SET_LATENCY_MONITOR);
587-
break;
588-
589571
case SNDK_NVME_SN861_DEV_ID_E1S:
590572
capabilities |= (SNDK_DRIVE_CAP_C0_LOG_PAGE |
591573
SNDK_DRIVE_CAP_C3_LOG_PAGE |
@@ -629,6 +611,24 @@ __u64 sndk_get_drive_capabilities(nvme_root_t r, struct nvme_dev *dev)
629611

630612
case SNDK_NVME_SNDK_VID:
631613
switch (read_device_id) {
614+
case SNDK_NVME_SNESSD1_DEV_ID_E1L:
615+
case SNDK_NVME_SNESSD1_DEV_ID_E2:
616+
case SNDK_NVME_SNESSD1_DEV_ID_E3S:
617+
case SNDK_NVME_SNESSD1_DEV_ID_E3L:
618+
case SNDK_NVME_SNESSD1_DEV_ID_U2:
619+
capabilities |= (SNDK_DRIVE_CAP_C0_LOG_PAGE |
620+
SNDK_DRIVE_CAP_C3_LOG_PAGE |
621+
SNDK_DRIVE_CAP_CA_LOG_PAGE |
622+
SNDK_DRIVE_CAP_OCP_C4_LOG_PAGE |
623+
SNDK_DRIVE_CAP_OCP_C5_LOG_PAGE |
624+
SNDK_DRIVE_CAP_UDUI |
625+
SNDK_DRIVE_CAP_VU_FID_CLEAR_PCIE |
626+
SNDK_DRIVE_CAP_CLOUD_SSD_VERSION |
627+
SNDK_DRIVE_CAP_LOG_PAGE_DIR |
628+
SNDK_DRIVE_CAP_DRIVE_STATUS |
629+
SNDK_DRIVE_CAP_SET_LATENCY_MONITOR);
630+
break;
631+
632632
case SNDK_NVME_SN7150_DEV_ID_1:
633633
case SNDK_NVME_SN7150_DEV_ID_2:
634634
case SNDK_NVME_SN7150_DEV_ID_3:

plugins/wdc/wdc-nvme.c

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,12 @@
9292
#define WDC_NVME_SNTMP_DEV_ID 0x2761
9393
#define WDC_NVME_SNTMP_DEV_ID_1 0x2763
9494

95+
#define WDC_NVME_SNESSD1_DEV_ID_E1L 0x2765
96+
#define WDC_NVME_SNESSD1_DEV_ID_E2 0x2766
97+
#define WDC_NVME_SNESSD1_DEV_ID_E3S 0x2767
98+
#define WDC_NVME_SNESSD1_DEV_ID_E3L 0x2768
99+
#define WDC_NVME_SNESSD1_DEV_ID_U2 0x2769
100+
95101
/* This id's are no longer supported, delete ?? */
96102
#define WDC_NVME_SN550_DEV_ID 0x2708
97103

@@ -190,7 +196,9 @@
190196
#define WDC_DRIVE_CAP_OCP_C5_LOG_PAGE 0x0000008000000000
191197
#define WDC_DRIVE_CAP_DEVICE_WAF 0x0000010000000000
192198
#define WDC_DRIVE_CAP_SET_LATENCY_MONITOR 0x0000020000000000
193-
#define WDC_DRIVE_CAP_RESERVED1 0x0000040000000000
199+
#define WDC_DRIVE_CAP_UDUI 0x0000040000000000
200+
#define WDC_DRIVE_CAP_RESIZE_SN861 0x0000080000000000
201+
194202
/* Any new capability flags should be added to the SNDK plugin */
195203

196204
#define WDC_DRIVE_CAP_SMART_LOG_MASK (WDC_DRIVE_CAP_C0_LOG_PAGE | \
@@ -1957,6 +1965,24 @@ static __u64 wdc_get_drive_capabilities(nvme_root_t r, struct nvme_dev *dev)
19571965

19581966
case WDC_NVME_SNDK_VID:
19591967
switch (read_device_id) {
1968+
case WDC_NVME_SNESSD1_DEV_ID_E1L:
1969+
case WDC_NVME_SNESSD1_DEV_ID_E2:
1970+
case WDC_NVME_SNESSD1_DEV_ID_E3S:
1971+
case WDC_NVME_SNESSD1_DEV_ID_E3L:
1972+
case WDC_NVME_SNESSD1_DEV_ID_U2:
1973+
capabilities |= (WDC_DRIVE_CAP_C0_LOG_PAGE |
1974+
WDC_DRIVE_CAP_C3_LOG_PAGE |
1975+
WDC_DRIVE_CAP_CA_LOG_PAGE |
1976+
WDC_DRIVE_CAP_OCP_C4_LOG_PAGE |
1977+
WDC_DRIVE_CAP_OCP_C5_LOG_PAGE |
1978+
WDC_DRIVE_CAP_UDUI |
1979+
WDC_DRIVE_CAP_VU_FID_CLEAR_PCIE |
1980+
WDC_DRIVE_CAP_CLOUD_SSD_VERSION |
1981+
WDC_DRIVE_CAP_LOG_PAGE_DIR |
1982+
WDC_DRIVE_CAP_DRIVE_STATUS |
1983+
WDC_DRIVE_CAP_SET_LATENCY_MONITOR);
1984+
break;
1985+
19601986
case WDC_NVME_SXSLCL_DEV_ID:
19611987
capabilities = WDC_DRIVE_CAP_DRIVE_ESSENTIALS;
19621988
break;
@@ -7392,6 +7418,11 @@ static int wdc_get_c0_log_page(nvme_root_t r, struct nvme_dev *dev, char *format
73927418
case WDC_NVME_SN655_DEV_ID_1:
73937419
case WDC_NVME_SNTMP_DEV_ID:
73947420
case WDC_NVME_SNTMP_DEV_ID_1:
7421+
case WDC_NVME_SNESSD1_DEV_ID_E1L:
7422+
case WDC_NVME_SNESSD1_DEV_ID_E2:
7423+
case WDC_NVME_SNESSD1_DEV_ID_E3S:
7424+
case WDC_NVME_SNESSD1_DEV_ID_E3L:
7425+
case WDC_NVME_SNESSD1_DEV_ID_U2:
73957426
if (uuid_index == 0) {
73967427
ret = nvme_get_print_ocp_cloud_smart_log(dev,
73977428
uuid_index,

0 commit comments

Comments
 (0)