Skip to content

itest: run lnd backend in remote-signing mode #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 31, 2025

Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into lnd v0.19.3-beta.

Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120

So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.

@coveralls
Copy link

coveralls commented Jul 31, 2025

Pull Request Test Coverage Report for Build 16798042155

Details

  • 45 of 45 (100.0%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.709%

Files with Coverage Reduction New Missed Lines %
asset/group_key.go 2 72.15%
mssmt/compacted_tree.go 2 79.49%
tapdb/sqlc/universe.sql.go 2 76.19%
tapdb/universe.go 2 82.56%
universe/syncer.go 2 86.59%
tapchannel/aux_leaf_signer.go 3 43.43%
tapgarden/custodian.go 6 76.99%
tapgarden/caretaker.go 8 77.3%
tapdb/multiverse.go 10 81.4%
Totals Coverage Status
Change from base Build 16785647395: 0.4%
Covered Lines: 60621
Relevant Lines: 106898

💛 - Coveralls

@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Jul 31, 2025
@levmi levmi moved this from 👀 In review to 🏗 In progress in Taproot-Assets Project Board Jul 31, 2025
@guggero guggero force-pushed the itest-remote-signer branch from d7f743e to e62df0f Compare August 4, 2025 12:12
guggero added 3 commits August 7, 2025 09:16
This commit adds a new flag to the integration test suite that starts
the single lnd node (alice) either in normal or in remote-signing mode.
In remote-signing mode, alice is actually a watch-only node that is
connected to a seconardy signer node over RPC.
To make sure `tapd` works when the connected `lnd` node is running in
remote-signing mode, we add a new CI target that runs all integration
tests in that mode.
@guggero guggero force-pushed the itest-remote-signer branch from e62df0f to f200946 Compare August 7, 2025 07:26
@guggero guggero marked this pull request as ready for review August 7, 2025 07:30
@guggero
Copy link
Member Author

guggero commented Aug 7, 2025

With lnd v0.19.3-beta.rc1 out, this is now out of draft.

@guggero guggero requested review from ffranr and GeorgeTsagk August 7, 2025 07:30
@guggero guggero moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants