From e90126b7b7959d2451b2ef60e83e12206e7b802b Mon Sep 17 00:00:00 2001 From: Guilherme Simoes Date: Fri, 13 Mar 2026 12:51:00 +0000 Subject: [PATCH] Less this. --- examples/common/MemMonitor.ts | 2 +- src/core/CoreNode.ts | 2 +- src/core/renderers/canvas/CanvasRenderer.ts | 4 ++-- src/core/renderers/canvas/CanvasShaderNode.ts | 6 +++--- src/core/renderers/webgl/WebGlRenderer.ts | 8 ++++---- src/core/renderers/webgl/WebGlShaderNode.ts | 6 +++--- src/core/textures/SubTexture.ts | 6 +++--- src/core/textures/Texture.ts | 2 +- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/examples/common/MemMonitor.ts b/examples/common/MemMonitor.ts index 4629efdb6..16750208b 100644 --- a/examples/common/MemMonitor.ts +++ b/examples/common/MemMonitor.ts @@ -227,7 +227,7 @@ export class MemMonitor extends Component { color: 0x000000ff, }); - const payload = this.renderer.stage.txMemManager.getMemoryInfo(); + const payload = renderer.stage.txMemManager.getMemoryInfo(); const { criticalThreshold, targetThreshold } = payload; const targetFraction = targetThreshold / criticalThreshold; this.targetTick.y = BAR_HEIGHT - BAR_HEIGHT * targetFraction; diff --git a/src/core/CoreNode.ts b/src/core/CoreNode.ts index d80de3a5e..363666666 100644 --- a/src/core/CoreNode.ts +++ b/src/core/CoreNode.ts @@ -895,7 +895,7 @@ export class CoreNode extends EventEmitter { // if the default texture isn't loaded yet, wait for it to load // this only happens when the node is created before the stage is ready - const dt = this.stage.defaultTexture; + const dt = stage.defaultTexture; if (dt !== null && dt.state !== 'loaded') { dt.once('loaded', () => this.setUpdateType(UpdateType.IsRenderable)); } diff --git a/src/core/renderers/canvas/CanvasRenderer.ts b/src/core/renderers/canvas/CanvasRenderer.ts index dd831b4f1..73c50955a 100644 --- a/src/core/renderers/canvas/CanvasRenderer.ts +++ b/src/core/renderers/canvas/CanvasRenderer.ts @@ -43,8 +43,8 @@ export class CanvasRenderer extends CoreRenderer { const canvas = platform.canvas!; this.canvas = canvas as HTMLCanvasElement; this.context = canvas.getContext('2d') as CanvasRenderingContext2D; - this.pixelRatio = this.stage.pixelRatio; - this.clearColor = normalizeCanvasColor(this.stage.clearColor); + this.pixelRatio = stage.pixelRatio; + this.clearColor = normalizeCanvasColor(stage.clearColor); } reset(): void { diff --git a/src/core/renderers/canvas/CanvasShaderNode.ts b/src/core/renderers/canvas/CanvasShaderNode.ts index 15117d4e7..2fae538b2 100644 --- a/src/core/renderers/canvas/CanvasShaderNode.ts +++ b/src/core/renderers/canvas/CanvasShaderNode.ts @@ -73,10 +73,10 @@ export class CanvasShaderNode< } if (prevKey.length > 0) { - this.stage.shManager.mutateShaderValueUsage(prevKey, -1); + stage.shManager.mutateShaderValueUsage(prevKey, -1); } - const computed = this.stage.shManager.getShaderValues( + const computed = stage.shManager.getShaderValues( this.valueKey, ) as Record; if (computed !== undefined) { @@ -84,7 +84,7 @@ export class CanvasShaderNode< } this.computed = {}; this.updater!(this.node as CoreNode); - this.stage.shManager.setShaderValues(this.valueKey, this.computed); + stage.shManager.setShaderValues(this.valueKey, this.computed); }; } } diff --git a/src/core/renderers/webgl/WebGlRenderer.ts b/src/core/renderers/webgl/WebGlRenderer.ts index 357f0e783..1c958c7f8 100644 --- a/src/core/renderers/webgl/WebGlRenderer.ts +++ b/src/core/renderers/webgl/WebGlRenderer.ts @@ -104,24 +104,24 @@ export class WebGlRenderer extends CoreRenderer { constructor(stage: Stage) { super(stage); - this.quadBuffer = new ArrayBuffer(this.stage.options.quadBufferSize); + this.quadBuffer = new ArrayBuffer(stage.options.quadBufferSize); this.fQuadBuffer = new Float32Array(this.quadBuffer); this.uiQuadBuffer = new Uint32Array(this.quadBuffer); this.mode = 'webgl'; - const platform = this.stage.platform; + const platform = stage.platform; const canvas = platform.canvas!; const glw = (this.glw = platform.createContext() as GlContextWrapper); glw.viewport(0, 0, canvas.width, canvas.height); - this.updateClearColor(this.stage.clearColor); + this.updateClearColor(stage.clearColor); glw.setBlend(true); glw.blendFunc(glw.ONE, glw.ONE_MINUS_SRC_ALPHA); - createIndexBuffer(glw, this.stage.bufferMemory); + createIndexBuffer(glw, stage.bufferMemory); this.system = { parameters: getWebGlParameters(this.glw), diff --git a/src/core/renderers/webgl/WebGlShaderNode.ts b/src/core/renderers/webgl/WebGlShaderNode.ts index 1217ba7fb..9e01925ae 100644 --- a/src/core/renderers/webgl/WebGlShaderNode.ts +++ b/src/core/renderers/webgl/WebGlShaderNode.ts @@ -94,10 +94,10 @@ export class WebGlShaderNode< } if (prevKey.length > 0) { - this.stage.shManager.mutateShaderValueUsage(prevKey, -1); + stage.shManager.mutateShaderValueUsage(prevKey, -1); } - const values = this.stage.shManager.getShaderValues( + const values = stage.shManager.getShaderValues( this.valueKey, ) as unknown as UniformCollection; if (values !== undefined) { @@ -112,7 +112,7 @@ export class WebGlShaderNode< vec4: {}, }; this.updater!(this.node as CoreNode); - this.stage.shManager.setShaderValues( + stage.shManager.setShaderValues( this.valueKey, this.uniforms as unknown as Record, ); diff --git a/src/core/textures/SubTexture.ts b/src/core/textures/SubTexture.ts index bcf3e4640..220c07432 100644 --- a/src/core/textures/SubTexture.ts +++ b/src/core/textures/SubTexture.ts @@ -91,14 +91,14 @@ export class SubTexture extends Texture { super(txManager); this.props = props; - assertTruthy(this.props.texture, 'SubTexture requires a parent texture'); + assertTruthy(props.texture, 'SubTexture requires a parent texture'); assertTruthy( - this.props.texture instanceof ImageTexture, + props.texture instanceof ImageTexture, 'SubTexture requires an ImageTexture parent', ); // Resolve parent texture from cache or fallback to provided texture - this.parentTexture = txManager.resolveParentTexture(this.props.texture); + this.parentTexture = txManager.resolveParentTexture(props.texture); if (this.renderableOwners.length > 0) { this.parentTexture.setRenderableOwner(this.subtextureId, true); diff --git a/src/core/textures/Texture.ts b/src/core/textures/Texture.ts index d2d16d21c..30be42249 100644 --- a/src/core/textures/Texture.ts +++ b/src/core/textures/Texture.ts @@ -202,7 +202,7 @@ export abstract class Texture extends EventEmitter { constructor(protected txManager: CoreTextureManager) { super(); - this.maxRetryCount = this.txManager.maxRetryCount; + this.maxRetryCount = txManager.maxRetryCount; } get dimensions(): Dimensions | null {