updated style of inline editors

casco · casco · commit 40fbd6256a05 · 2019-03-08T14:46:07.000-03:00
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/class/on.of..st b/TasksLogger.package/InPlacePropertyEditorComponent.class/class/on.of..st
@@ -1,4 +1,4 @@
-instance-creation
+instance creation
 on: aSelector of: anObject
 	^ self new
 		on: aSelector of: anObject;
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/rendeDisplayingOn..st b/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/rendeDisplayingOn..st
@@ -9,4 +9,4 @@ rendeDisplayingOn: html
 				with: [ html tbsGlyphIcon iconPencil ] ].
 	(textArea
 		ifFalse: [ html paragraph ]
-		ifTrue: [ html preformatted ]) with: (subject perform: getSelector)
+		ifTrue: [ html preformatted ]) with: self valueFromSubject
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/save.st b/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/save.st
@@ -1,5 +1,4 @@
 callbacks
 save
-
-	subject perform: setSelector with: newValue .
-	editing := false.
+	self valueToSubject.
+	editing := false
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/style.st b/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/style.st
@@ -0,0 +1,3 @@
+style
+style
+	^ 'pre {padding : unset; background-color : unset; border : unset; font-family : unset; font-size: unset}'
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/valueFromSubject.st b/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/valueFromSubject.st
@@ -0,0 +1,9 @@
+private
+valueFromSubject
+	| value |
+	value := subject perform: getSelector.
+	value isString
+		ifFalse: [ value := 'Error: ' , getSelector printString
+				, ' should return a String - got a '
+				, (value printStringLimitedTo: 100) ].
+	^ value
diff --git a/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/valueToSubject.st b/TasksLogger.package/InPlacePropertyEditorComponent.class/instance/valueToSubject.st
@@ -0,0 +1,3 @@
+private
+valueToSubject
+	subject perform: setSelector with: newValue

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-instance-creation`
	`1`	`+instance creation`
`2`	`2`	`on: aSelector of: anObject`
`3`	`3`	`^ self new`
`4`	`4`	`on: aSelector of: anObject;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+style`
	`2`	`+style`
	`3`	`+ ^ 'pre {padding : unset; background-color : unset; border : unset; font-family : unset; font-size: unset}'`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+private`
	`2`	`+valueToSubject`
	`3`	`+ subject perform: setSelector with: newValue`