Code and documenation clean up

Author: joachimmetz

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ([2.71])
 
 AC_INIT(
  [libfsntfs],
- [20251019],
+ [20251028],
  [[email protected]])
 
 AC_CONFIG_SRCDIR(

documentation/New Technologies File System (NTFS).asciidoc

@@ -608,7 +608,7 @@ The size of the attribute including the 8 bytes of the attribute type and size
 | 9 | 1 | | Name size (or name length) +
 Contains the number of characters without the end-of-string character
 | 10 | 2 | | Name offset +
-Contains an offset relative from the start of the MFT entry
+Contains an offset relative from the start of the MFT attribute
 | 12 | 2 | | Attribute data flags +
 See section: <<mft_attribute_data_flags,MFT attribute data flags>>
 | 14 | 2 | | Attribute identifier (or instance) +

fsntfstools/info_handle.c

@@ -4805,10 +4805,12 @@ int info_handle_file_entry_value_fprint(
 		 info_handle->notify_stream,
 		 "\n" );
 	}
-	if( libfsntfs_file_entry_get_parent_file_reference(
-	     file_entry,
-	     &parent_file_reference,
-	     error ) != 1 )
+	result = libfsntfs_file_entry_get_parent_file_reference(
+	          file_entry,
+	          &parent_file_reference,
+	          error );
+       
+	if( result == -1 )
 	{
 		libcerror_error_set(
 		 error,
@@ -4823,7 +4825,8 @@ int info_handle_file_entry_value_fprint(
 	 info_handle->notify_stream,
 	 "\tParent file reference\t\t: " );
 
-	if( parent_file_reference == 0 )
+	if( ( result == 0 )
+	 || ( parent_file_reference == 0 ) )
 	{
 		fprintf(
 		 info_handle->notify_stream,

libfsntfs/libfsntfs_file_entry.c

@@ -1344,7 +1344,7 @@ int libfsntfs_file_entry_get_parent_file_reference(
 {
 	libfsntfs_internal_file_entry_t *internal_file_entry = NULL;
 	static char *function                                = "libfsntfs_file_entry_get_parent_file_reference";
-	int result                                           = 1;
+	int result                                           = 0;
 
 	if( file_entry == NULL )
 	{
@@ -1374,19 +1374,28 @@ int libfsntfs_file_entry_get_parent_file_reference(
 		return( -1 );
 	}
 #endif
-	if( libfsntfs_directory_entry_get_parent_file_reference(
-	     internal_file_entry->directory_entry,
-	     parent_file_reference,
-	     error ) != 1 )
+	if( internal_file_entry->directory_entry == NULL )
 	{
-		libcerror_error_set(
-		 error,
-		 LIBCERROR_ERROR_DOMAIN_RUNTIME,
-		 LIBCERROR_RUNTIME_ERROR_GET_FAILED,
-		 "%s: unable to retrieve parent reference from directory entry.",
-		 function );
+		result = 0;
+	}
+	else
+	{
+		result = libfsntfs_directory_entry_get_parent_file_reference(
+		          internal_file_entry->directory_entry,
+		          parent_file_reference,
+		          error );
+	       
+		if( result != 1 )
+		{
+			libcerror_error_set(
+			 error,
+			 LIBCERROR_ERROR_DOMAIN_RUNTIME,
+			 LIBCERROR_RUNTIME_ERROR_GET_FAILED,
+			 "%s: unable to retrieve parent reference from directory entry.",
+			 function );
 
-		result = -1;
+			result = -1;
+		}
 	}
 #if defined( HAVE_LIBFSNTFS_MULTI_THREAD_SUPPORT )
 	if( libcthreads_read_write_lock_release_for_read(

libfsntfs/libfsntfs_index_value.c

@@ -494,7 +494,7 @@ ssize_t libfsntfs_index_value_read(
 			 0 );
 		}
 #endif
-		if( data_offset > ( data_size - 4 ) )
+		if( data_offset > ( data_size - 8 ) )
 		{
 			libcerror_error_set(
 			 error,