SDL GPU fails to create pipeline and ssbo under DirectX

[zanadoman]

Hi!

I tried to enable DirectX backend support in my SDL GPU renderer library
but I'm running into a strange issue with pipeline/SSBO creation.

I tested my renderer with Vulkan backend on both Windows 10 and Linux
it worked fine, without any validation error.

On Windows 10 (Tiny 10 in Qemu) I'm running into the following error message every time:

ERROR: Could not create buffer!! Error Code: The application made a call that is invalid. Either the parameters of the call or the state of some object was incorrect.
Enable the D3D debug layer in order to see details via debug messages. (0x887A0001)
ERROR: Could not create buffer!! Error Code: The application made a call that is invalid. Either the parameters of the call or the state of some object was incorrect.
Enable the D3D debug layer in order to see details via debug messages. (0x887A0001)

(If I place the pipeline creation before the SSBO creation the error message is similar.)

Unfortunately I can't test it on real hardware right now :(.

Initialization code:
Renderer init
SSBO creation

Thank you for any help! :)

Edit: I tested it on a real hardware with Windows 10 and the result is the same.

[thatcosmonaut]

Have you tried enabling the debug layer?

[zanadoman]

I always set the debug parameter to true when creating the device. Or am I missing something?
Edit1: I will try to install it and look into it.
Edit2: I have the Graphics Tools installed, debug mode enabled on device creation, still same results.

[thatcosmonaut]

You have to run the program through an editor that can display debug messages, like Visual Studio, to see the debug output from D3D12.

[zanadoman]

I downloaded Sysinternals DebugView and launched my test application, got the following result:

D3D12 ERROR: ID3D12Device::CreateShaderResourceView: The Dimensions of the View are invalid due to at least one of the following conditions. Assuming this Format (0x27, R32_TYPELESS), FirstElement (value = 0) must be between 0 and the maximum offset of the Buffer, -1, inclusively. With the current FirstElement, NumElements (value = 0) must be between 1 and 0, inclusively, in order that the View fit on the Buffer. [ STATE_CREATION ERROR #31: CREATESHADERRESOURCEVIEW_INVALIDDIMENSIONS]

DESKTOP-D4HST29.LOG

[thatcosmonaut]

It appears that creating a storage buffer of less than 4 bytes is invalid. We can add validation for this.

[zanadoman]

Okay, I will fix the initial size of the ssbo on creation, can you keep the issue open until I test the pipeline creation?

[zanadoman]

I tested it, changed the SSBO initial size to 4 bytes and worked. The pipeline creation fails because of invalid shader model (lib_6_8) but DirectX requires vs_6_2 or ps_6_2. Now I tried to compile my shaders with the said model and it fails for the fragment shaders every time.

Im running into the following error message:

ERROR: Failed to compile DXIL from SPIR-V: HLSL compilation failed: error: validation errors
shading.frag.spv:45:18: error: sample_* instructions require resource to be declared to return UNORM, SNORM or FLOAT.
note: at '%38 = call %dx.types.ResRet.f32 @dx.op.sample.f32(i32 60, %dx.types.Handle %1, %dx.types.Handle %7, float %12, float %13, float undef, float undef, i32 0, i32 0, i32 undef, float undef)' in block '#2' of function 'main'.

By default I'm using dxc to compile my spirv and dxil shaders, spirv works every time, but dxil fails with 6_2. I tried to compile from my original glsl shaders with spirv-cross then dxc, same issue. Also shadercross gives me the exact same error message. Huge thanks for your patience and help, I'm trying to make this work for hours.

Shader directory

Edit 1:
I also tried disabling validation in dxc with -Vd flag to let the compilation pass, but pipeline creation still fails with corrupted shaders message.

Edit 2:
I cloned the SDL_gpu_examples repo to test the hlsl -> dxil compilation with shadercross. I got the same error messages for every fragment shader that contains Texture2D with SamplerStates. The only difference between dxc and shadercross is that shadercross creates the output file but leaves it empty.

SOLUTION
Finally, I managed to find a solution for the shader compilation problem. I used version dxc 1.8.2502 which failed every time for fragment shaders, but with dxc 1.9 the compilation succeeds. I would recommend to mention this information in a wiki section related to SDL shadercross.

Thank you for your previous help!