fix(Settings): remove max preload setting

As the max preload (buffer duration) setting is now set automatically,
there is no longer the need to keep the setting around.

Ref: 405a916

Author: FineFindus

app/src/main/java/com/github/libretube/constants/PreferenceKeys.kt

@@ -60,7 +60,6 @@ object PreferenceKeys {
     const val SEEK_INCREMENT = "seek_increment"
     const val DEFAULT_RESOLUTION = "default_res"
     const val DEFAULT_RESOLUTION_MOBILE = "default_res_mobile"
-    const val BUFFERING_GOAL = "buffering_goal"
     const val PLAYER_AUDIO_FORMAT = "player_audio_format"
     const val PLAYER_AUDIO_QUALITY = "player_audio_quality"
     const val PLAYER_AUDIO_QUALITY_MOBILE = "player_audio_quality_mobile"

app/src/main/java/com/github/libretube/helpers/PlayerHelper.kt

@@ -188,12 +188,6 @@ object PlayerHelper {
             false
         )
 
-    private val bufferingGoal: Int
-        get() = PreferenceHelper.getString(
-            PreferenceKeys.BUFFERING_GOAL,
-            "50"
-        ).toInt() * 1000
-
     val sponsorBlockEnabled: Boolean
         get() = PreferenceHelper.getBoolean(
             "sb_enabled_key",

app/src/main/res/values/strings.xml

@@ -158,8 +158,6 @@
     <string name="show_updates">Check updates automatically</string>
     <string name="related_streams">Related content</string>
     <string name="related_streams_summary">Show similar streams alongside what you watch</string>
-    <string name="buffering_goal">Preloading</string>
-    <string name="buffering_goal_summary">Max. amount of seconds of video to buffer</string>
     <string name="playerVideoFormat">Video format for player</string>
     <string name="no_audio">No audio</string>
     <string name="no_video">No video</string>

app/src/main/res/xml/player_settings.xml

@@ -166,13 +166,6 @@
 
     <PreferenceCategory app:title="@string/misc">
 
-        <com.github.libretube.ui.preferences.EditNumberPreference
-            android:icon="@drawable/ic_time"
-            app:defaultValue="50"
-            app:key="buffering_goal"
-            app:summary="@string/buffering_goal_summary"
-            app:title="@string/buffering_goal" />
-
         <SwitchPreferenceCompat
             android:icon="@drawable/ic_call"
             android:summary="@string/playback_during_call_summary"