Fix a number of errors when closing an actively used async websocket #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexiforest
reviewed
Jun 25, 2025
| if isinstance(payload, str): | ||
| payload = payload.encode() | ||
|
|
||
| # TODO: Why does concurrently sending fail |
Owner
There was a problem hiding this comment.
Was this TODO resolved somehow?
Contributor
Author
There was a problem hiding this comment.
yeah, it's because the curl websockets implementation is abysmal
Contributor
Author
|
Superseded by #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a number of issues when implementing websockets in an actual async environment (i.e. constantly calling
recv()while connect/close logic is handled concurrently). A lot of these issues have been fixed by #570 (and seemingly by curl updates in general), but the below remain.aselect()call inrecv()deadlocks if the socket is closed while waiting, as it waits forever (or untiltimeout) for a closed websocket to be open againself.closedraces andcurl_easy_getinfo,curl_ws_recv, andcurl_ws_sendare called with null curl handles (as they were closed between the check happening and the function being called), throwing some funTypeErrorsOSErrorsrelating to the socket descriptors being closedThere might be more, but this is all I could find for now.
I will update this PR to fix any similar issues that arise with the merging of #570 (therefore this PR depends on that PR)