CI workflow - lsf_view

[TamaroWalter]

To be able to test lsf_unification, our CI workflow should build the lsf_view.

One use-case is:

• the scheduled task that reads the courses/categories from the lsf view and builds the lsf_unification datatables

This is very important as without filled lsf_unification datatables no courses can be generated

[dlmsr]

Ok, I agree, we would need this for Behat tests I guess. However, how should we do this? We would need to modify the test step of the learnweb-workflows repo, right? I wouldn't want to have configuration only relevant to local_lsf_unification inside this central repo. So we either need to use a YAML custom to this repo or find a way to patch the YAML. I am not super familiar with GitHub Actions, maybe there is a way to do this.

Anyways, we need to setup a PostgreSQL service container and initialize it. You mentioned some example data, maybe you could add it to the repo as examples/lsf-view.sql. So that we can use it in the GHA workflow to initialize the database.

For PHPUnit tests, we should not rely on a running database connection but instead provide a mocked LSF view filled with example data. Otherwise we would not only be testing the system under test but also the database providing the LSF view and PHP's PostgreSQL functions.

[TamaroWalter]

I agree with you, our Unit tests should only test our internal functions. I was primarily thinking about the behat tests like:

• As an admin, I map lsf courses to moodle categories
• As a teacher, I add a new course with lsf data

I think a good way would be something like an extra yaml file in lsf_unification that gets executed in our central workflow. So there would be needed changes too (Changes that support extra steps that get inserted dynamically)