Skip to content

[Remove Vuetify from Studio] Remove unused :v-deep styles from info modal #5095

Open
@MisRob

Description

@MisRob

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Some of these :v-deep styles in shared/views/InfoModal seem to never be used:

::v-deep p {
font-size: 12pt;
line-height: normal;
color: var(--v-grey-darken3);
}

Image

Remove all styles that don't take any effect from here. This will also remove dependency on Vuetify color variable.

InfoModal is used from more locations in the app. One way to preview this is 'About licenses' modal in Settings > Storage > Request more space.

How to get there

  • Login as [email protected] with password a
  • Go to Settings > Storage > Request more space
  • Click Open form
  • Click on info button next to Who can use your content? (Note that button click is broken, fix here. Before the fix is released, temporarily modify code in InfoModal to make the modal visible.)

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • None

Acceptance criteria

  • The specification above is followed.
  • All user interactions are manually tested with no regressions.
  • There are no visual differences.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions