Skip to content

Remove use of multiple h1 heading elements on info modal #5093

Open
@MisRob

Description

@MisRob

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Complexity: Low

Summary

shared/views/InfoModal wraps heading texts provided via the header slot in <h1> heading elements. This results in incorrect semantic structure with multiple <h1> in the modal.

<h2> should be used for headers provided via the header slot, leaving the main modal title the only <h1>.

InfoModal is used from more locations in the app. One way to preview this is 'About licenses' modal in Settings > Storage > Request more space.

Image

How to get there

  • Login as [email protected] with password a
  • Go to Settings > Storage > Request more space
  • Click Open form
  • Click on info button next to Who can use your content? (Note that button click is broken, fix here. Before the fix is released, temporarily modify code in InfoModal to make the modal visible.)

Acceptance criteria

  • Manually test the correct markup structure in the modal
  • There are no visual changes

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions