Skip to content

refactor(QED): name even anomaly-cancellation planes - #1507

Merged
jstoobysmith merged 3 commits into
leanprover-community:masterfrom
catlover-bot:refactor/qed-even-plane-naming
Aug 11, 2026
Merged

refactor(QED): name even anomaly-cancellation planes#1507
jstoobysmith merged 3 commits into
leanprover-community:masterfrom
catlover-bot:refactor/qed-even-plane-naming

Conversation

@catlover-bot

Copy link
Copy Markdown
Contributor

Summary

  • name the two even anomaly-cancellation planes Unshifted and Shifted, following the terminology introduced for the odd case in refactor(QED): name odd anomaly-cancellation planes #1502
  • move the corresponding basis and plane APIs under Unshifted / Shifted namespaces, including basisAsCharges, basis, planeCharges, and planeLinSols
  • update references and documentation in Even/LineInCubic.lean and Even/Parameterization.lean
  • keep the mathematical content unchanged

Contributes to #1046.

Validation

  • lake build +Physlib.QFT.QED.AnomalyCancellation.Even.BasisLinear +Physlib.QFT.QED.AnomalyCancellation.Even.LineInCubic +Physlib.QFT.QED.AnomalyCancellation.Even.Parameterization
  • ./scripts/lint-style.sh
  • lake build (9269 jobs)

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@github-actions github-actions Bot added the t-qft label Aug 11, 2026
@nateabr nateabr self-assigned this Aug 11, 2026
@catlover-bot
catlover-bot marked this pull request as ready for review August 11, 2026 13:28

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments about some names which probably could also do with being updated.

Comment thread Physlib/QFT/QED/AnomalyCancellation/Even/BasisLinear.lean Outdated
Comment thread Physlib/QFT/QED/AnomalyCancellation/Even/BasisLinear.lean Outdated
Comment thread Physlib/QFT/QED/AnomalyCancellation/Even/LineInCubic.lean Outdated
@jstoobysmith

Copy link
Copy Markdown
Member

awaiting-author

@github-actions github-actions Bot added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 11, 2026
@catlover-bot

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Aug 11, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks - approved. Assuming the linters pass, I will merge

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Aug 11, 2026
@jstoobysmith
jstoobysmith merged commit 2310526 into leanprover-community:master Aug 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-qft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants