refactor(QED): name even anomaly-cancellation planes - #1507
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
jstoobysmith
left a comment
There was a problem hiding this comment.
Added some small comments about some names which probably could also do with being updated.
|
awaiting-author |
|
-awaiting-author |
jstoobysmith
left a comment
There was a problem hiding this comment.
Many thanks - approved. Assuming the linters pass, I will merge
Summary
UnshiftedandShifted, following the terminology introduced for the odd case in refactor(QED): name odd anomaly-cancellation planes #1502Unshifted/Shiftednamespaces, includingbasisAsCharges,basis,planeCharges, andplaneLinSolsEven/LineInCubic.leanandEven/Parameterization.leanContributes to #1046.
Validation
lake build +Physlib.QFT.QED.AnomalyCancellation.Even.BasisLinear +Physlib.QFT.QED.AnomalyCancellation.Even.LineInCubic +Physlib.QFT.QED.AnomalyCancellation.Even.Parameterization./scripts/lint-style.shlake build(9269 jobs)