Skip to content

Add initial condensed matter directory structure - #1498

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
WahajAyub:feat/condensed-matter-scaffolding
Aug 12, 2026
Merged

Add initial condensed matter directory structure#1498
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
WahajAyub:feat/condensed-matter-scaffolding

Conversation

@WahajAyub

Copy link
Copy Markdown
Contributor

Summary

  • Adds documentation-only top-level scaffolding for Crystal, LatticeModels, BandTheory,
    ManyBody, Topology, and Response.
  • Updates the CondensedMatter overview to describe these scopes.
  • Leaves the existing TightBindingChain and Thermoelectric modules in place.
  • Introduces no substantive APIs, allowing future condensed-matter work to develop in focused PRs.

Declarations

No definitions or lemmas are added or removed.

Reviewer map

  1. Physlib/CondensedMatter/Basic.lean: overview of the directory structure.
  2. Six new Basic.lean files: documentation-only scope statements.
  3. Physlib.lean: sorted public imports for the new modules.

Validation

  • lake build
  • lake exe lint_all
  • ./scripts/lint-style.sh

Co-authored-by: OpenAI GPT-5.6 Pro <noreply@openai.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@github-actions github-actions Bot added the t-condensed-matter Condensed matter label Aug 10, 2026
@WahajAyub WahajAyub closed this Aug 10, 2026
@WahajAyub WahajAyub reopened this Aug 10, 2026
@jstoobysmith

Copy link
Copy Markdown
Member

@WahajAyub Many thanks for this PR. This layout looks good to me! You marked this PR as a draft, do you want me to approve it for review now, or do you have other changes you are thinking of making before?

@jstoobysmith

Copy link
Copy Markdown
Member

awaiting-author

@github-actions github-actions Bot added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 11, 2026
@WahajAyub
WahajAyub marked this pull request as ready for review August 11, 2026 16:15
@WahajAyub

Copy link
Copy Markdown
Contributor Author

It was marked as review because some of the GitHub linting checks were still due. Marked ready now!

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Aug 11, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - looks good to me. Will merge shortly. Many thanks :)

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Aug 12, 2026
@jstoobysmith
jstoobysmith merged commit 1d839cd into leanprover-community:master Aug 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-condensed-matter Condensed matter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants