From 520e61263313830e98ab364e798070fa05104031 Mon Sep 17 00:00:00 2001 From: Jiva DeVoe Date: Wed, 15 May 2013 13:29:32 -0700 Subject: [PATCH 1/5] Fixing a warning of a missing selector. --- Additions/NSString+STAdditions.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Additions/NSString+STAdditions.m b/Additions/NSString+STAdditions.m index 61daca8..cf2d52e 100644 --- a/Additions/NSString+STAdditions.m +++ b/Additions/NSString+STAdditions.m @@ -27,7 +27,7 @@ // #import "STUtils.h" - +#include @implementation NSString (STAdditions) From bf021ae510e2a23d828c4880c4dc15084c85083d Mon Sep 17 00:00:00 2001 From: Jiva DeVoe Date: Wed, 15 May 2013 13:30:06 -0700 Subject: [PATCH 2/5] Fixed a problem where currentIndex is not initialized. This caused a warning with the CLANG analyzer. --- Additions/NSObject+STAdditions.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Additions/NSObject+STAdditions.m b/Additions/NSObject+STAdditions.m index 1495601..47efeb6 100644 --- a/Additions/NSObject+STAdditions.m +++ b/Additions/NSObject+STAdditions.m @@ -45,7 +45,7 @@ - (id)performSelectorOnMainThread:(SEL)selector withArguments:(NSArray *)argumen [invocation setTarget:self]; [invocation retainArguments]; - for (int currentIndex; currentIndex < arguments.count; currentIndex++) { + for (int currentIndex = 0; currentIndex < arguments.count; currentIndex++) { id currentArgument = [arguments objectAtIndex:currentIndex]; [invocation setArgument:¤tArgument atIndex:currentIndex]; } From ff8f6518b32477956ab60d575af09fc3c6d3814a Mon Sep 17 00:00:00 2001 From: Jiva DeVoe Date: Fri, 7 Jun 2013 15:08:30 -0700 Subject: [PATCH 3/5] Fixed a warning about a missing method. --- iOS/UIKit/STEditableTableViewCell.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iOS/UIKit/STEditableTableViewCell.m b/iOS/UIKit/STEditableTableViewCell.m index f7a5921..a83d7b9 100644 --- a/iOS/UIKit/STEditableTableViewCell.m +++ b/iOS/UIKit/STEditableTableViewCell.m @@ -61,7 +61,7 @@ - (id)initWithDelegate:(id)inDelegate; [label release]; UITextField *entryField = [[UITextField alloc] initWithFrame:CGRectZero]; - entryField.textColor = [UIColor tableCellEditableTextColor]; + entryField.textColor = [UIColor blackColor]; entryField.contentVerticalAlignment = UIControlContentVerticalAlignmentCenter; entryField.font = [UIFont systemFontOfSize:16.0]; entryField.delegate = inDelegate; From b292500edcbfbde5f4dfd196f5b26b2fbd1ffdf7 Mon Sep 17 00:00:00 2001 From: Jiva DeVoe Date: Fri, 7 Jun 2013 15:24:07 -0700 Subject: [PATCH 4/5] Fixing a warning. FYI, arguably, the stuff for Base64 should be a submodule, but maybe you don't like submodules... so fine. :) --- Additions/NSString+STAdditions.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Additions/NSString+STAdditions.m b/Additions/NSString+STAdditions.m index cf2d52e..71e1278 100644 --- a/Additions/NSString+STAdditions.m +++ b/Additions/NSString+STAdditions.m @@ -29,6 +29,9 @@ #import "STUtils.h" #include +// Get this from: https://github.com/nicklockwood/Base64.git +#import "Base64.h" + @implementation NSString (STAdditions) #pragma mark Paths From d4c176dc67835405e52be51ed6e4435a61666cc5 Mon Sep 17 00:00:00 2001 From: Jiva DeVoe Date: Fri, 7 Jun 2013 15:37:01 -0700 Subject: [PATCH 5/5] Fixed 2 deprecation warnings. These calls are now deprecated in iOS 6 --- Additions/NSString+STAdditions.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Additions/NSString+STAdditions.m b/Additions/NSString+STAdditions.m index 71e1278..80464ee 100644 --- a/Additions/NSString+STAdditions.m +++ b/Additions/NSString+STAdditions.m @@ -274,12 +274,12 @@ - (NSDate *)ISO8601DateValue; - (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset; { - return [self drawInRect:inRect withFont:inFont lineBreakMode:UILineBreakModeTailTruncation alignment:UITextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset]; + return [self drawInRect:inRect withFont:inFont lineBreakMode:NSLineBreakByTruncatingTail alignment:NSTextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset]; } - (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont lineBreakMode:(UILineBreakMode)inLineBreakMode color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset; { - return [self drawInRect:inRect withFont:inFont lineBreakMode:inLineBreakMode alignment:UITextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset]; + return [self drawInRect:inRect withFont:inFont lineBreakMode:inLineBreakMode alignment:NSTextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset]; } - (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont lineBreakMode:(UILineBreakMode)inLineBreakMode alignment:(UITextAlignment)alignment color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset;