Merge pull request #120 from launchcodedev/fix/secret-encrypt-stdin-newlines

Fix: Keep newlines when encrypting from stdin

Author: joelgallant

app-config-node/src/prompts.test.ts

@@ -37,8 +37,7 @@ describe('consumeStdin', () => {
         .then(() => end())
         .catch(() => {});
 
-      // we expect newlines to be eaten up, since this function is used for html and base64 data
-      expect(await consumeStdin()).toBe('foobarbaz');
+      expect(await consumeStdin()).toBe('foo\nbar\nbaz\n');
     });
   });
 });

app-config-node/src/prompts.ts

@@ -1,8 +1,7 @@
-import readline from 'readline';
-import prompts from 'prompts';
-import type { PromptObject } from 'prompts';
 import { AppConfigError } from '@app-config/core';
 import { logger } from '@app-config/logging';
+import type { PromptObject } from 'prompts';
+import prompts from 'prompts';
 
 export async function promptUser<T>(options: Omit<PromptObject, 'name'>): Promise<T> {
   const { named } = await prompts({ ...options, name: 'named' });
@@ -31,14 +30,9 @@ export async function promptUserWithRetry<T>(
 
 export async function consumeStdin(): Promise<string> {
   return new Promise((resolve, reject) => {
-    const rl = readline.createInterface({ input: process.stdin });
-
-    let buffer = '';
-    rl.on('line', (line) => {
-      buffer += line;
-    });
-
-    rl.on('error', reject);
-    rl.on('close', () => resolve(buffer));
+    const buffers: Buffer[] = [];
+    process.stdin.on('data', (data) => buffers.push(data));
+    process.stdin.on('error', reject);
+    process.stdin.on('end', () => resolve(Buffer.concat(buffers).toString('utf8')));
   });
 }