Skip to content

Commit a399aa3

Browse files
authored
[8.x] Supports PHP 8.4 (#1131)
* [8.x] Supports PHP 8.4 Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip * wip --------- Signed-off-by: Mior Muhammad Zaki <[email protected]>
1 parent fbed996 commit a399aa3

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

.github/workflows/browser-tests.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,16 @@ jobs:
2020
matrix:
2121
php: [8.1, 8.2, 8.3]
2222
laravel: [10, 11]
23-
phpunit: [10.5, '11.0']
23+
phpunit: [10.5, 11]
24+
include:
25+
- php: 8.4
26+
laravel: 11
27+
phpunit: 11.3
2428
exclude:
2529
- php: 8.1
2630
laravel: 11
2731
- laravel: 10
28-
phpunit: '11.0'
32+
phpunit: 11
2933

3034
name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} - PHPUnit ${{ matrix.phpunit }}
3135

@@ -44,7 +48,7 @@ jobs:
4448

4549
- name: Install dependencies
4650
run: |
47-
composer update --prefer-dist --no-interaction --no-progress --with=illuminate/support:^${{ matrix.laravel }} --with=phpunit/phpunit:^${{ matrix.phpunit }}
51+
composer update --prefer-dist --no-interaction --no-progress --with=laravel/framework:^${{ matrix.laravel }} --with=phpunit/phpunit:^${{ matrix.phpunit }}
4852
4953
- name: Upgrade Chrome Driver
5054
run: php vendor/bin/testbench dusk:chrome-driver --detect
@@ -56,6 +60,6 @@ jobs:
5660
run: php vendor/bin/testbench serve --no-reload &
5761

5862
- name: Execute tests
59-
run: php vendor/bin/phpunit -c phpunit.dusk.xml.dist
63+
run: php vendor/bin/phpunit -c phpunit.dusk.xml.dist --display-deprecations --fail-on-deprecation
6064
env:
6165
APP_URL: http://127.0.0.1:8000

.github/workflows/tests.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,16 @@ jobs:
2020
matrix:
2121
php: [8.1, 8.2, 8.3]
2222
laravel: [10, 11]
23-
phpunit: [10.5, '11.0']
23+
phpunit: [10.5, 11]
24+
include:
25+
- php: 8.4
26+
laravel: 11
27+
phpunit: 11.3
2428
exclude:
2529
- php: 8.1
2630
laravel: 11
2731
- laravel: 10
28-
phpunit: '11.0'
32+
phpunit: 11
2933

3034
name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} - PHPUnit ${{ matrix.phpunit }}
3135

@@ -44,20 +48,19 @@ jobs:
4448

4549
- name: Install dependencies
4650
run: |
47-
composer require "illuminate/contracts:^${{ matrix.laravel }}" "phpunit/phpunit:^${{ matrix.phpunit }}" --dev --no-update
48-
composer update --prefer-dist --no-interaction --no-progress
51+
composer update --prefer-dist --no-interaction --no-progress --with="laravel/framework:^${{ matrix.laravel }}" --with="phpunit/phpunit:^${{ matrix.phpunit }}"
4952
5053
- name: Execute tests
51-
run: vendor/bin/phpunit -c phpunit.xml.dist
54+
run: vendor/bin/phpunit -c phpunit.xml.dist --display-deprecations --fail-on-deprecation
5255

5356
stub-tests:
5457
runs-on: ubuntu-22.04
5558

5659
strategy:
5760
fail-fast: true
5861
matrix:
59-
php: [8.2]
60-
laravel: [10]
62+
php: [8.2, 8.3, 8.4]
63+
laravel: [10, 11]
6164

6265
name: Test Stubs PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }}
6366

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"guzzlehttp/guzzle": "^7.5",
2121
"illuminate/console": "^10.0|^11.0",
2222
"illuminate/support": "^10.0|^11.0",
23-
"php-webdriver/webdriver": "^1.9.0",
23+
"php-webdriver/webdriver": "^1.15.2",
2424
"symfony/console": "^6.2|^7.0",
2525
"symfony/finder": "^6.2|^7.0",
2626
"symfony/process": "^6.2|^7.0",

0 commit comments

Comments
 (0)