Skip to content

Commit 71f0776

Browse files
author
Jason Chevrie
authored
Merge pull request #66 from jchevrie/Dev-Jason
Small improvement in code: - remove a warning text message that always appears - improve speed of reading and writing for the saving of 3D volumes - temporary fix the grabbing of 3D ultrasound volumes
2 parents c759db5 + f6ad8e9 commit 71f0776

File tree

2 files changed

+5
-28
lines changed

2 files changed

+5
-28
lines changed

modules/ustk_core/src/io/usRawFileParser.cpp

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,7 @@
4949
void usRawFileParser::read(usImage3D<unsigned char> &image3D, const std::string &rawFilename)
5050
{
5151
std::ifstream fileStream(rawFilename.c_str(), std::ios::in | std::ios::binary);
52-
unsigned int i = 0;
53-
while (i < image3D.getSize()) {
54-
char c;
55-
fileStream.get(c);
56-
image3D.getData()[i] = c;
57-
i++;
58-
}
52+
fileStream.read((char *)image3D.getData(), image3D.getSize()*sizeof(unsigned char));
5953
fileStream.close();
6054
}
6155

@@ -67,11 +61,7 @@ void usRawFileParser::read(usImage3D<unsigned char> &image3D, const std::string
6761
void usRawFileParser::write(const usImage3D<unsigned char> &image3D, const std::string &rawFilename)
6862
{
6963
std::fstream fileStream(rawFilename.c_str(), std::ios::out | std::ios::binary);
70-
unsigned int i = 0;
71-
while (i < image3D.getSize()) {
72-
fileStream.put(image3D.getConstData()[i]);
73-
i++;
74-
}
64+
fileStream.write((const char*)image3D.getConstData(), image3D.getSize()*sizeof(unsigned char));
7565
fileStream.close();
7666
}
7767

@@ -83,11 +73,7 @@ void usRawFileParser::write(const usImage3D<unsigned char> &image3D, const std::
8373
void usRawFileParser::read(usImageRF3D<short> &image3D, const std::string &rawFilename)
8474
{
8575
std::ifstream fileStream(rawFilename.c_str(), std::ios::in | std::ios::binary);
86-
unsigned int i = 0;
87-
while (i < image3D.getSize()) {
88-
fileStream.read((char *)(image3D.bitmap + i), sizeof(short));
89-
i++;
90-
}
76+
fileStream.read((char*)image3D.bitmap, image3D.getSize()*sizeof(short));
9177
fileStream.close();
9278
}
9379

@@ -99,11 +85,7 @@ void usRawFileParser::read(usImageRF3D<short> &image3D, const std::string &rawFi
9985
void usRawFileParser::write(const usImageRF3D<short> &image3D, const std::string &rawFilename)
10086
{
10187
std::fstream fileStream(rawFilename.c_str(), std::ios::out | std::ios::binary);
102-
unsigned int i = 0;
103-
while (i < image3D.getSize()) {
104-
fileStream.write((char *)(image3D.getConstData() + i), sizeof(short));
105-
i++;
106-
}
88+
fileStream.write((const char*)image3D.getConstData(), image3D.getSize()*sizeof(short));
10789
fileStream.close();
10890
}
10991

modules/ustk_grabber/src/usNetworkGrabberPreScan3D.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,14 +187,9 @@ void usNetworkGrabberPreScan3D::dataArrived()
187187
m_motorSettings.setMotorRadius(m_imageHeader.motorRadius);
188188

189189
// set data info
190-
m_grabbedImage.setFrameCount(m_imageHeader.frameCount);
190+
m_grabbedImage.setFrameCount(m_imageHeader.frameCount>1?(m_imageHeader.frameCount-1):0);
191191
m_grabbedImage.setFramesPerVolume(m_imageHeader.framesPerVolume);
192192

193-
// warning if timestamps are close (< 10 ms)
194-
if (m_imageHeader.timeStamp - m_grabbedImage.getTimeStamp() < 10) {
195-
std::cout << "WARNING : new image received with an acquisition timestamp close to previous image (<10ms)"
196-
<< std::endl;
197-
}
198193
m_grabbedImage.setTimeStamp(m_imageHeader.timeStamp);
199194

200195
m_grabbedImage.resize(m_imageHeader.frameWidth, m_imageHeader.frameHeight);

0 commit comments

Comments
 (0)