Introduce a Virtual Machine Instance lister #160
Conversation
The logic and dependencies on the creation of the Controller and the Node services differ. Splitting them will make them more manageable. Signed-off-by: Alí Felán <[email protected]>
This modifies and introduces two new commands to the generate_clients.sh in hack: one to generate informers for KubeVirt, and another one to generate the listers. It also adds a go install for each binary. The go get commands were skipped during the generation to minimize changes on the commmit. We also refactor a bit to have a consistent style accross the file. Signed-off-by: Alí Felán <[email protected]>
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @alifelan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will help reduce the number of API calls performed when checking for VirtualMachineInstances. Signed-off-by: Alí Felán <[email protected]>
2 participants
What this PR does / why we need it:
Introduces informers and listers for Virtual Machine Instances. The KubeVirtCSI Driver polls for the Virtual Machine Instances when performing ControllerPublishVolume and ControllerUnpublishVolume. When many operations are running, this will end up causing rate limiter issues. While removing polling and performing early returns with retriable errors is an option, that involves a larger change (early returns would expose the errors to the user as soon as we start check the status).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This was developed on top of #159
Release note: