-
Notifications
You must be signed in to change notification settings - Fork 53
Update linux-bridge component #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we dont have tagged version of plugins package that containers bridge CNI version with the new disableContainerInterface flag, consume that latest version from main branch. Signed-off-by: Or Mergi <[email protected]>
PUSH_IMAGES=yes make bump-linux-bridge Signed-off-by: Petr Horacek <[email protected]>
|
|
Verified on local env with latest Kubevirt, the correct bridge CNI is build and deployed by CNAO. The VM is fail to create as expected because its not possible to set both |
RamLavi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ormergi
Moving the update strategy to "static" is less preferable.
Can you explain why you need this disableContainerInterface option?
Is this change urgent? If not, can you try and reach out to https://github.com/containernetworking/plugins maintainers and kindly ask them to issue a release?
Hi @RamLavi, thanks for looking at this 🙂 I am in touch with https://github.com/containernetworking/plugins maintainers and we will have it released eventually, once we do, I will post a PR to set CNAO to use the tagged version. |
I'm totally down with that. Please remember to set it back to tagged when a new tag is available. |
RamLavi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |

What this PR does / why we need it:
Update the linux-bridge component to latest in order to bridge the latest changes of bridge CNI that include the new
disableContainerInterfaceoption containernetworking/plugins#997Special notes for your reviewer:
Since there is no tagged version of container network plugins yet, consume that latest version from main branch containernetworking/plugins@14bdce5
Release note: