Merge pull request #2500 from gouyang/settings_general_tab

lkladnit · web-flow · commit b875cfc7cd09 · 2025-04-12T07:21:34.000+03:00
CNV-57355: add test for cluster general settings
diff --git a/cypress/cypress.config.js b/cypress/cypress.config.js
@@ -25,7 +25,7 @@ module.exports = defineConfig({
   },
   retries: {
     openMode: 0,
-    runMode: 3,
+    runMode: 0,
   },
   screenshotOnRunFailure: true,
   screenshotsFolder: './gui-test-screenshots/screenshots/',
diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts
@@ -0,0 +1,21 @@
+export {};
+declare global {
+  // eslint-disable-next-line @typescript-eslint/no-namespace
+  namespace Cypress {
+    interface Chainable {
+      checkHCOSpec(spec: string, matchString: string, include: boolean): void;
+    }
+  }
+}
+
+Cypress.Commands.add('checkHCOSpec', (spec: string, matchString: string, include: boolean) => {
+  cy.exec(
+    `oc get -n kubevirt-hyperconverged hyperconverged kubevirt-hyperconverged -o jsonpath='{${spec}}'`,
+  ).then((result) => {
+    if (include) {
+      expect(result.stdout).contain(matchString);
+    } else {
+      expect(result.stdout).not.contain(matchString);
+    }
+  });
+});
diff --git a/cypress/support/index.ts b/cypress/support/index.ts
@@ -4,6 +4,7 @@ import './nav.ts';
 import './project.ts';
 import './resource.ts';
 import './selectors.ts';
+import './commands.ts';
 
 declare global {
   namespace Cypress {
diff --git a/cypress/tests/e2e/a-setup.cy.ts b/cypress/tests/e2e/a-setup.cy.ts
@@ -41,18 +41,21 @@ describe('Prepare the cluster for test', () => {
     cy.contains('button[role="tab"]', 'User').click();
     cy.contains(manageKeysText).click();
     cy.contains(authSSHKey, { timeout: 20000 }).should('be.visible');
-    cy.wait(2000);
-    // configure new public ssh key
-    cy.get('.settings-tab__content').then(() => {
-      cy.contains('Select project').click();
-      cy.byLegacyTestID(TEST_NS).click({ force: true });
-      cy.get('button.project-ssh-row__secret-name').click();
-      cy.get(useExisting).click();
-      cy.contains('Select secret').click();
-      cy.byButtonText(TEST_SECRET_NAME).click();
-      cy.clickSaveBtn();
+    cy.wait(10000);
+    cy.get('.settings-tab__content').then(($body) => {
+      if ($body.text().includes(TEST_SECRET_NAME)) {
+        cy.task('log', 'secret is configured');
+      } else {
+        cy.contains('Select project').click();
+        cy.byLegacyTestID(TEST_NS).click({ force: true });
+        cy.get('button.project-ssh-row__secret-name').click();
+        cy.get(useExisting).click();
+        cy.contains('Select secret').click();
+        cy.byButtonText(TEST_SECRET_NAME).click();
+        cy.clickSaveBtn();
+      }
+      cy.contains('button.project-ssh-row__secret-name', TEST_SECRET_NAME).should('exist');
     });
-    cy.contains('button.project-ssh-row__secret-name', TEST_SECRET_NAME).should('exist');
   });
 
   it('create example VM', () => {
diff --git a/cypress/tests/e2e/b-overview.cy.ts b/cypress/tests/e2e/b-overview.cy.ts
@@ -1,19 +1,11 @@
-import { TEST_NS } from '../../utils/const/index';
-import { authSSHKey } from '../../utils/const/string';
-import { tabModal } from '../../views/actions';
-import { addNew, manageKeysText, secretName, uploadSecret } from '../../views/selector-catalog';
-import { userButtonTxt } from '../../views/selector-instance';
 import { tab } from '../../views/tab';
 
-const testSecret = 'test-secret';
-
 describe('Test Virtualization Overview', () => {
   before(() => {
-    cy.visit('');
+    cy.visitOverview();
   });
 
   it('overview page is loaded', () => {
-    cy.visitOverview();
     cy.contains('VirtualMachine statuses').should('exist');
   });
 
@@ -31,31 +23,4 @@ describe('Test Virtualization Overview', () => {
     tab.navigateToSettings();
     cy.contains('General settings').should('be.visible');
   });
-
-  it('test saving SSH key', () => {
-    cy.byButtonText(userButtonTxt).click();
-    cy.byButtonText(manageKeysText).click();
-    cy.byButtonText(manageKeysText)
-      .parent()
-      .parent()
-      .within(() => {
-        cy.contains(authSSHKey, { timeout: 20000 }).should('be.visible');
-      });
-    // configure public ssh key when it's not configured
-    cy.get('.settings-tab__content').then(($body) => {
-      if ($body.text().includes('Select project')) {
-        cy.contains('Select project').click();
-        cy.byLegacyTestID(TEST_NS).click({ force: true });
-      }
-    });
-    cy.get('button.project-ssh-row__secret-name').click();
-    cy.get(tabModal).within(() => {
-      cy.get(addNew).click();
-      cy.dropFile('./fixtures/rsa.pub', 'rsa.pub', uploadSecret);
-      cy.wait(1000);
-      cy.get(secretName).type(testSecret);
-      cy.clickSaveBtn();
-    });
-    cy.byButtonText(testSecret).should('exist');
-  });
 });
diff --git a/cypress/tests/e2e/catalog-filter.cy.ts b/cypress/tests/e2e/catalog-filter.cy.ts
@@ -7,12 +7,10 @@ import { cardTitleV6 } from '../../views/selector-overview';
 
 describe('Test filter in InstanceType', () => {
   before(() => {
-    cy.visit('');
-    cy.switchToVirt();
+    cy.visitCatalog();
   });
 
   it('test hint in InstanceTypes boot volume', () => {
-    cy.visitCatalog();
     cy.contains('Select volume to boot from').find('svg').click();
     cy.contains(
       'From the Volume table, select a bootable volume to boot your VirtualMachine',
@@ -55,7 +53,7 @@ describe('Test filter in InstanceType', () => {
     cy.contains(colName, 'centos').should('not.exist');
   });
 
-  it('check instanceType class in catalog', () => {
+  xit('check instanceType class in catalog', () => {
     cy.byButtonText('User').click();
     cy.get('input[aria-label="Filter menu items"]').clear().type('.small');
     cy.contains('n1').should('not.exist');
diff --git a/cypress/tests/e2e/check-tab-yaml.cy.ts b/cypress/tests/e2e/check-tab-yaml.cy.ts
@@ -7,14 +7,10 @@ import { navigateToConfigurationSubTab, subTabName, tab } from '../../views/tab'
 
 describe('Check all virtualization pages can be loaded', () => {
   before(() => {
-    cy.visit('');
+    cy.visitVMs();
   });
 
   describe('Check VirtualMachines page', () => {
-    it('visit VM list page', () => {
-      cy.visitVMs();
-    });
-
     it('start example vm', () => {
       cy.byLegacyTestID(Example).click();
       cy.get(sel.iconStartBtn, { timeout: MINUTE }).click();
diff --git a/cypress/tests/e2e/create-vm.cy.ts b/cypress/tests/e2e/create-vm.cy.ts
@@ -11,8 +11,8 @@ import { vm, waitForStatus } from '../../views/vm-flow';
 
 describe('Create VMs from InstanceType', () => {
   before(() => {
-    cy.visit('');
-    cy.switchToVirt();
+    cy.visitOverview();
+    cy.visitCatalog();
     cy.switchProject(TEST_NS);
   });
 
@@ -49,7 +49,6 @@ describe('Create VMs from Template', () => {
     tab.navigateToConfiguration();
     cy.contains(VM_TMPL_CUST.description).should('be.visible');
     cy.contains(VM_TMPL_CUST.hostname).should('be.visible');
-    cy.byButtonText('Boot management').click();
     cy.contains(VM_TMPL_CUST.bootMode).should('be.visible');
     tab.navigateToConsole();
     cy.contains('.pf-v6-c-clipboard-copy', VM_TMPL_CUST.cloudInitUname).should('be.visible');
diff --git a/cypress/tests/e2e/d-networking.cy.ts b/cypress/tests/e2e/d-networking.cy.ts
@@ -2,8 +2,8 @@ import { NAD_BRIDGE, NAD_LOCALNET, NAD_OVN } from '../../utils/const/nad';
 import { createNAD, deleteNAD } from '../../views/nad';
 
 describe('Test network attachments', () => {
-  before(() => {
-    cy.visit('');
+  beforeEach(() => {
+    cy.visitNAD();
   });
 
   it('create NAD with MAC Spoof checked', () => {
diff --git a/cypress/tests/e2e/template-list.cy.ts b/cypress/tests/e2e/template-list.cy.ts
@@ -4,11 +4,6 @@ import { catalogNav } from '../../views/selector';
 import * as tView from '../../views/selector-template';
 
 describe('Test template list page', () => {
-  before(() => {
-    cy.visit('');
-    cy.switchToVirt();
-  });
-
   beforeEach(() => {
     cy.clickVirtLink(catalogNav);
     cy.visitTemplates();
diff --git a/cypress/tests/overview.cy.ts b/cypress/tests/overview.cy.ts
@@ -1,2 +1,3 @@
 import './overview/overview-tab.cy.ts';
 import './overview/top-consumers-tab.cy.ts';
+import './overview/settings-cluster-general.cy.ts';
diff --git a/cypress/tests/overview/settings-cluster-general.cy.ts b/cypress/tests/overview/settings-cluster-general.cy.ts
@@ -0,0 +1,102 @@
+import { OS_IMAGES_NS, SECOND } from '../../utils/const/index';
+import { tab } from '../../views/tab';
+
+describe('Test Cluster General settings', () => {
+  before(() => {
+    tab.navigateToOverview();
+    tab.navigateToSettings();
+  });
+
+  describe('Check installed version appears', () => {
+    it('check version', () => {
+      cy.get('[data-test="detail-item-value"]').contains('4');
+      cy.get('[data-test="detail-item-value"]').contains('Up to date');
+    });
+  });
+
+  describe('Test Live migration', () => {
+    it('set live migration limits', () => {
+      cy.contains('General settings').click();
+      cy.contains('Live migration').click();
+      cy.get('input[name="parallelMigrationsPerCluster"]').clear().type('4');
+      cy.get('input[name="parallelOutboundMigrationsPerNode"]').clear().type('1');
+      cy.contains('Set live migration network').click();
+      cy.wait(1000);
+    });
+
+    it('verify live migration limits in HCO', () => {
+      const maxPerCluster = '.spec.liveMigrationConfig.parallelMigrationsPerCluster';
+      const maxPerNode = '.spec.liveMigrationConfig.parallelOutboundMigrationsPerNode';
+      const spec = '.spec.liveMigrationConfig';
+      const cmd = `oc get -n kubevirt-hyperconverged hyperconverged kubevirt-hyperconverged -o jsonpath='{${spec}}'`;
+      cy.exec(cmd).then((res) => {
+        cy.task('log', res.stdout);
+      });
+      cy.checkHCOSpec(maxPerCluster, '4', true);
+      cy.checkHCOSpec(maxPerNode, '1', true);
+    });
+  });
+
+  describe('Test Memory density', () => {
+    it('enable memory density', () => {
+      cy.contains('Memory density').click();
+      cy.get('[id="memory-density-feature"]').find('input[type="checkbox"]').check({ force: true });
+      cy.wait(10 * SECOND);
+    });
+
+    it('verify higherWorkloadDensity in HCO', () => {
+      const percentage = '.spec.higherWorkloadDensity.memoryOvercommitPercentage';
+      cy.checkHCOSpec(percentage, '150', true);
+    });
+
+    it('disable memory density', () => {
+      cy.get('[id="memory-density-feature"]')
+        .find('input[type="checkbox"]')
+        .uncheck({ force: true });
+      cy.wait(10 * SECOND);
+    });
+
+    it('verify higherWorkloadDensity in HCO', () => {
+      const percentage = '.spec.higherWorkloadDensity.memoryOvercommitPercentage';
+      cy.checkHCOSpec(percentage, '100', true);
+    });
+  });
+
+  describe('Test Automatic images download', () => {
+    it('disable centos-stream-9-image-cron', () => {
+      cy.contains('Templates and images management').click();
+      cy.contains('Automatic images download').click();
+      cy.get('#centos-stream9-image-cron-auto-image-download-switch')
+        .find('input.pf-v6-c-switch__input')
+        .uncheck({ force: true });
+      cy.wait(10 * SECOND);
+    });
+
+    it('delete centos-stream9 volumesnapshot', () => {
+      const cmd = `oc delete datavolume -n ${OS_IMAGES_NS} -l cdi.kubevirt.io/dataImportCron=centos-stream9-image-cron`;
+      cy.exec(cmd);
+      cy.wait(10 * SECOND);
+    });
+
+    it('enable centos-stream9-image-cron again', () => {
+      cy.get('#centos-stream9-image-cron-auto-image-download-switch')
+        .find('input.pf-v6-c-switch__input')
+        .check({ force: true });
+      cy.wait(60 * SECOND);
+    });
+
+    it(
+      'verify volume is downloaded again',
+      {
+        retries: {
+          runMode: 10,
+        },
+      },
+      () => {
+        cy.wait(15 * SECOND);
+        const cmd = `oc get datavolume -n ${OS_IMAGES_NS} -l cdi.kubevirt.io/dataImportCron=centos-stream9-image-cron | grep centos-stream9`;
+        cy.exec(cmd);
+      },
+    );
+  });
+});
diff --git a/cypress/tests/overview/top-consumers-tab.cy.ts b/cypress/tests/overview/top-consumers-tab.cy.ts
@@ -1,5 +1,4 @@
 import { topConsumerCard } from '../../views/overview';
-import { Perspective, switchPerspective } from '../../views/perspective';
 import { tab } from '../../views/tab';
 
 const enum Card {
@@ -13,13 +12,11 @@ const enum Card {
 
 describe('Test Virtualization Top consumer tab', () => {
   before(() => {
-    cy.visit('');
-    switchPerspective(Perspective.Administrator);
+    cy.visitOverview();
+    tab.navigateToTopConsumers();
   });
 
   it('ID(CNV-9295) check data available for cpu, memory and storage', () => {
-    cy.visitOverview();
-    tab.navigateToTopConsumers();
     cy.get(topConsumerCard).eq(Card.CPU).should('not.contain', 'No data available');
     cy.get(topConsumerCard).eq(Card.Memory).should('not.contain', 'No data available');
     cy.get(topConsumerCard).eq(Card.Storage_throughput).should('not.contain', 'No data available');
diff --git a/cypress/utils/const/index.ts b/cypress/utils/const/index.ts
@@ -7,7 +7,7 @@ export const OCP_NS = 'openshift'; // use default can reduce flaky
 export const TEST_PVC_NAME = 'auto-test-pvc';
 export const DEFAULT_VM_NAME = 'example';
 export const DEFAULT_TEMPLATE_NAME = 'example';
-export const OS_IMAGES_NS = 'openshift-virtualization-os-images';
+export const OS_IMAGES_NS = 'kubevirt-os-images';
 export const POLICY_NAME = 'policy-auto-test';
 export const DATASOURCE_NAME = 'datasource-auto-test';
 export const YAML_DS_NAME = 'example';
diff --git a/cypress/views/nad.ts b/cypress/views/nad.ts
@@ -22,7 +22,6 @@ export const localnetSubnet = 'input[name="ovn-k8s-cni-overlay-localnet.subnets"
 export const exclude = 'input[name="ovn-k8s-cni-overlay-localnet.excludeSubnets"]';
 
 export const createNAD = (nad: nadData) => {
-  cy.visitNAD();
   cy.byButtonText('Create').click();
   cy.get(name).clear().type(nad.name);
   cy.get(description).type(nad.description);
