Add support for storage migration for multiple namespaces

pcbailey · pcbailey · commit 4db6f0b9ca30 · 2025-10-02T10:07:17.000-04:00
diff --git a/locales/en/plugin__kubevirt-plugin.json b/locales/en/plugin__kubevirt-plugin.json
@@ -171,6 +171,7 @@
   "An error occurred": "An error occurred",
   "An error occurred during the cloning process": "An error occurred during the cloning process",
   "An error occurred during the upload process": "An error occurred during the upload process",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "An existing MigPlan for this namespace was found. ",
   "An InstanceType must be selected": "An InstanceType must be selected",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "An OpenShift project is an alternative representation of a Kubernetes namespace.",
diff --git a/locales/es/plugin__kubevirt-plugin.json b/locales/es/plugin__kubevirt-plugin.json
@@ -176,6 +176,7 @@
   "An error occurred": "Ocurrió un error",
   "An error occurred during the cloning process": "Ocurrió un error durante el proceso de clonación",
   "An error occurred during the upload process": "Ocurrió un error durante el proceso de carga",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "Se encontró un MigPlan existente para este espacio de nombre. ",
   "An InstanceType must be selected": "Se debe seleccionar un InstanceType",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "Un proyecto OpenShift es una representación alternativa de un espacio de nombres de Kubernetes.",
diff --git a/locales/fr/plugin__kubevirt-plugin.json b/locales/fr/plugin__kubevirt-plugin.json
@@ -176,6 +176,7 @@
   "An error occurred": "Une erreur s’est produite",
   "An error occurred during the cloning process": "Une erreur s'est produite lors du processus de clonage",
   "An error occurred during the upload process": "Une erreur s'est produite lors du processus de téléchargement",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "Un MigPlan existant pour cet espace de noms a été trouvé. ",
   "An InstanceType must be selected": "Un InstanceType doit être sélectionné",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "Un projet OpenShift est une représentation alternative d’un espace de noms Kubernetes.",
diff --git a/locales/ja/plugin__kubevirt-plugin.json b/locales/ja/plugin__kubevirt-plugin.json
@@ -171,6 +171,7 @@
   "An error occurred": "エラーが発生しました",
   "An error occurred during the cloning process": "クローン作成中にエラーが発生しました",
   "An error occurred during the upload process": "アップロード中にエラーが発生しました",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "このnamespace の既存の MigPlan が見つかりました。",
   "An InstanceType must be selected": "InstanceType を選択する必要があります",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "OpenShift プロジェクトは、Kubernetes namespace を別の形で表現したものです。",
diff --git a/locales/ko/plugin__kubevirt-plugin.json b/locales/ko/plugin__kubevirt-plugin.json
@@ -171,6 +171,7 @@
   "An error occurred": "오류가 발생했습니다",
   "An error occurred during the cloning process": "복제 프로세스 중 오류가 발생했습니다.",
   "An error occurred during the upload process": "업로드 프로세스 중 오류 발생",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "이 네임스페이스의 기존 MigPlan이 발견되었습니다. ",
   "An InstanceType must be selected": "InstanceType을 선택해야 합니다.",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "OpenShift 프로젝트는 Kubernetes 네임스페이스의 대체 표현입니다.",
diff --git a/locales/zh/plugin__kubevirt-plugin.json b/locales/zh/plugin__kubevirt-plugin.json
@@ -171,6 +171,7 @@
   "An error occurred": "发生错误",
   "An error occurred during the cloning process": "克隆过程中出现错误",
   "An error occurred during the upload process": "上传过程中出现错误",
+  "An existing MigPlan for these namespaces was found.": "An existing MigPlan for these namespaces was found.",
   "An existing MigPlan for this namespace was found. ": "找到用于此命名空间的现有 MigPlan。",
   "An InstanceType must be selected": "必须选择一个 InstanceType",
   "An OpenShift project is an alternative representation of a Kubernetes namespace.": "OpenShift 项目是 Kubernetes 命名空间的一个替代表示。",
diff --git a/src/utils/resources/migrations/constants.ts b/src/utils/resources/migrations/constants.ts
@@ -36,6 +36,7 @@ export type PersistentVolumesMigPlan = {
 export type MigPlan = K8sResourceCommon & {
   spec: {
     [key: string]: any;
+    namespaces?: string[];
     persistentVolumes?: PersistentVolumesMigPlan[];
   };
   status?: { conditions: K8sResourceCondition[]; suffix: string };
diff --git a/src/utils/utils/utils.ts b/src/utils/utils/utils.ts
@@ -237,3 +237,5 @@ export const isIPV6LinkLocal = (ip: string): boolean => {
 
 export const removeLinkLocalIPV6 = (ipAddress: IPAddress[]) =>
   ipAddress.filter((item) => !isIPV6LinkLocal(item?.ip?.trim()));
+
+export const removeDuplicates = (array: any[]) => Array.from(new Set(array));
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationModal.tsx b/src/views/virtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationModal.tsx
@@ -8,36 +8,34 @@ import Loading from '@kubevirt-utils/components/Loading/Loading';
 import StateHandler from '@kubevirt-utils/components/StateHandler/StateHandler';
 import useDefaultStorageClass from '@kubevirt-utils/hooks/useDefaultStorage/useDefaultStorageClass';
 import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
-import {
-  modelToGroupVersionKind,
-  modelToRef,
-  PersistentVolumeClaimModel,
-} from '@kubevirt-utils/models';
+import { modelToRef } from '@kubevirt-utils/models';
 import {
   DEFAULT_MIGRATION_NAMESPACE,
   MigPlanModel,
 } from '@kubevirt-utils/resources/migrations/constants';
 import { getName, getNamespace } from '@kubevirt-utils/resources/shared';
-import { isEmpty } from '@kubevirt-utils/utils/utils';
+import { isEmpty, removeDuplicates } from '@kubevirt-utils/utils/utils';
 import { getCluster } from '@multicluster/helpers/selectors';
-import useK8sWatchData from '@multicluster/hooks/useK8sWatchData';
 import { k8sDelete } from '@openshift-console/dynamic-plugin-sdk';
 import {
   Alert,
   AlertVariant,
+  List,
+  ListItem,
   Modal,
   ModalBody,
   Wizard,
   WizardHeader,
   WizardStep,
 } from '@patternfly/react-core';
+import useMigrationNamespacesPVCs from '@virtualmachines/actions/components/VirtualMachineMigration/hooks/useMigrationNamespacesPVCs';
+import VirtualMachineMigrationDestinationTab from '@virtualmachines/actions/components/VirtualMachineMigration/tabs/VirtualMachineMigrationDestinationTab';
+import VirtualMachineMigrationDetails from '@virtualmachines/actions/components/VirtualMachineMigration/tabs/VirtualMachineMigrationDetails';
+import VirtualMachineMigrationReviewTab from '@virtualmachines/actions/components/VirtualMachineMigration/tabs/VirtualMachineMigrationReviewTab';
 
 import useCreateEmptyMigPlan from './hooks/useCreateEmptyMigPlan';
-import useExistingMigrationPlan from './hooks/useExistingMigrationPlan';
+import useExistingMigPlanConflicts from './hooks/useExistingMigPlanConflicts';
 import useMigrationState from './hooks/useMigrationState';
-import VirtualMachineMigrationDestinationTab from './tabs/VirtualMachineMigrationDestinationTab';
-import VirtualMachineMigrationDetails from './tabs/VirtualMachineMigrationDetails';
-import VirtualMachineMigrationReviewTab from './tabs/VirtualMachineMigrationReviewTab';
 import { entireVMSelected, getMigratableVMPVCs } from './utils/utils';
 import VirtualMachineMigrationStatus from './VirtualMachineMigrationStatus';
 
@@ -55,36 +53,29 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
   vms,
 }) => {
   const { t } = useKubevirtTranslation();
+  const vmNamespaces = removeDuplicates(vms?.map((vm) => getNamespace(vm)));
 
-  const migrationNamespace = getNamespace(vms?.[0]);
   const cluster = getCluster(vms?.[0]);
   const [selectedStorageClass, setSelectedStorageClass] = useState('');
 
   const [currentMigPlanCreation, migPlanCreationLoaded, migPlanCreationError] =
-    useCreateEmptyMigPlan(migrationNamespace, cluster);
+    useCreateEmptyMigPlan(vmNamespaces, cluster);
 
-  const [existingMigPlan, migrationPlansLoaded] = useExistingMigrationPlan(
+  const { migPlansLoaded, namespaceConflicts } = useExistingMigPlanConflicts(
     currentMigPlanCreation,
-    migrationNamespace,
+    vmNamespaces,
     cluster,
   );
 
   const [selectedPVCs, setSelectedPVCs] = useState<IoK8sApiCoreV1PersistentVolumeClaim[] | null>(
     null,
   );
 
-  const [namespacePVCs, loaded, loadingError] = useK8sWatchData<
-    IoK8sApiCoreV1PersistentVolumeClaim[]
-  >({
-    cluster,
-    groupVersionKind: modelToGroupVersionKind(PersistentVolumeClaimModel),
-    isList: true,
-    namespace: migrationNamespace,
-  });
+  const [pvcsInNamespaces, loaded, loadError] = useMigrationNamespacesPVCs(cluster, vmNamespaces);
 
   const vmsPVCs = useMemo(
-    () => vms.map((vm) => getMigratableVMPVCs(vm, namespacePVCs)).flat(),
-    [vms, namespacePVCs],
+    () => vms.map((vm) => getMigratableVMPVCs(vm, pvcsInNamespaces)).flat(),
+    [vms, pvcsInNamespaces],
   );
 
   const [{ clusterDefaultStorageClass, sortedStorageClasses }, scLoaded] =
@@ -108,7 +99,7 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
   const { migMigration, migrationError, migrationLoading, migrationStarted, onSubmit } =
     useMigrationState(
       currentMigPlanCreation,
-      namespacePVCs,
+      pvcsInNamespaces,
       pvcsToMigrate,
       destinationStorageClass,
     );
@@ -130,7 +121,8 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
       });
   }, [onClose, migrationStarted, currentMigPlanCreation]);
 
-  const disableForExistingMigPlan = !isEmpty(existingMigPlan) || !migrationPlansLoaded;
+  const disableForExistingMigPlan = !isEmpty(namespaceConflicts) || !migPlansLoaded;
+
   return (
     <Modal
       className="virtual-machine-migration-modal"
@@ -139,7 +131,7 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
       variant="large"
     >
       <ModalBody>
-        <StateHandler error={loadingError || migPlanCreationError} hasData loaded>
+        <StateHandler error={loadError || migPlanCreationError} hasData loaded>
           {migrationStarted ? (
             <VirtualMachineMigrationStatus
               migMigration={migMigration}
@@ -170,11 +162,22 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
                 id="wizard-migration-details"
                 name={t('Migration details')}
               >
-                {!isEmpty(existingMigPlan) && (
+                {!isEmpty(namespaceConflicts) && (
                   <Alert
-                    title={t('An existing MigPlan for this namespace was found. ')}
+                    title={
+                      namespaceConflicts.length === 1
+                        ? t('An existing MigPlan for this namespace was found. ')
+                        : t('An existing MigPlan for these namespaces was found.')
+                    }
                     variant={AlertVariant.danger}
                   >
+                    {namespaceConflicts.length > 1 && (
+                      <List className="pf-v6-u-my-sm">
+                        {namespaceConflicts.map((ns) => (
+                          <ListItem key={ns}>{ns}</ListItem>
+                        ))}
+                      </List>
+                    )}
                     <Trans ns="plugin__kubevirt-plugin" t={t}>
                       Click{' '}
                       <Link
@@ -188,7 +191,7 @@ const VirtualMachineMigrateModal: FC<VirtualMachineMigrateModalProps> = ({
                   </Alert>
                 )}
 
-                {isEmpty(existingMigPlan) && loaded && scLoaded && (
+                {isEmpty(namespaceConflicts) && loaded && scLoaded && (
                   <VirtualMachineMigrationDetails
                     pvcs={vmsPVCs}
                     selectedPVCs={selectedPVCs}
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationStatus.tsx b/src/views/virtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationStatus.tsx
@@ -4,6 +4,12 @@ import { Link } from 'react-router-dom-v5-compat';
 import ErrorAlert from '@kubevirt-utils/components/ErrorAlert/ErrorAlert';
 import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
 import { modelToRef } from '@kubevirt-utils/models';
+import {
+  DEFAULT_MIGRATION_NAMESPACE,
+  MigMigration,
+  MigMigrationStatuses,
+  MigPlanModel,
+} from '@kubevirt-utils/resources/migrations/constants';
 import { Timestamp } from '@openshift-console/dynamic-plugin-sdk';
 import {
   ActionList,
@@ -17,13 +23,6 @@ import {
 } from '@patternfly/react-core';
 import { CloseIcon } from '@patternfly/react-icons';
 
-import {
-  DEFAULT_MIGRATION_NAMESPACE,
-  MigMigration,
-  MigMigrationStatuses,
-  MigPlanModel,
-} from '../../../../../utils/resources/migrations/constants';
-
 import useProgressMigration from './hooks/useProgressMigration';
 import { getMigMigrationStatusLabel } from './utils/utils';
 import VirtualMachineMigrationRollback from './VirtualMachineMigrationRollback';
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useCreateEmptyMigPlan.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useCreateEmptyMigPlan.ts
@@ -7,14 +7,14 @@ import { kubevirtK8sCreate } from '@multicluster/k8sRequests';
 import { getEmptyMigPlan } from '../utils/migrateVMs';
 
 const useCreateEmptyMigPlan = (
-  namespace: string,
+  namespaces: string[],
   cluster?: string,
 ): [migPlan: MigPlan, loaded: boolean, error: Error | null] => {
   const [migPlan, setMigPlan] = useState<MigPlan>(null);
   const [error, setError] = useState<Error | null>();
 
   useEffect(() => {
-    const emptyMigPlan = getEmptyMigPlan(namespace);
+    const emptyMigPlan = getEmptyMigPlan(namespaces);
 
     kubevirtK8sCreate({
       cluster,
@@ -25,7 +25,7 @@ const useCreateEmptyMigPlan = (
         setMigPlan(createdMigPlan);
       })
       .catch(setError);
-  }, [namespace, cluster]);
+  }, [JSON.stringify(namespaces), cluster]);
 
   return [migPlan, !isEmpty(migPlan), error];
 };
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useExistingMigPlanConflicts.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useExistingMigPlanConflicts.ts
@@ -0,0 +1,52 @@
+import { useMemo } from 'react';
+import intersection from 'lodash/intersection';
+
+import { modelToGroupVersionKind } from '@kubevirt-utils/models';
+import {
+  DEFAULT_MIGRATION_NAMESPACE,
+  MigPlan,
+  MigPlanModel,
+} from '@kubevirt-utils/resources/migrations/constants';
+import { getName } from '@kubevirt-utils/resources/shared';
+import useK8sWatchData from '@multicluster/hooks/useK8sWatchData';
+import { getExistingMigPlanNamespaces } from '@virtualmachines/actions/components/VirtualMachineMigration/utils/utils';
+
+type UseExistingMigPlanConflicts = (
+  currentMigPlanCreation: MigPlan,
+  vmNamespaces: string[],
+  cluster?: string,
+) => {
+  migPlansLoaded: boolean;
+  namespaceConflicts: string[];
+};
+
+const useExistingMigPlanConflicts: UseExistingMigPlanConflicts = (
+  currentMigPlanCreation,
+  vmNamespaces,
+  cluster,
+) => {
+  const [migrationPlans, loaded, loadError] = useK8sWatchData<MigPlan[]>({
+    cluster,
+    groupVersionKind: modelToGroupVersionKind(MigPlanModel),
+    isList: true,
+    namespace: DEFAULT_MIGRATION_NAMESPACE,
+  });
+
+  const filteredMigPlans = migrationPlans.filter(
+    (plan) => getName(plan) !== getName(currentMigPlanCreation),
+  );
+
+  const existingMigPlanNamespaces = useMemo(
+    () => getExistingMigPlanNamespaces(filteredMigPlans),
+    [filteredMigPlans],
+  );
+  const namespaceConflicts = intersection(vmNamespaces, existingMigPlanNamespaces);
+  const migPlansLoaded = loaded && !loadError;
+
+  return {
+    migPlansLoaded,
+    namespaceConflicts,
+  };
+};
+
+export default useExistingMigPlanConflicts;
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useExistingMigrationPlan.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useExistingMigrationPlan.ts
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useMigrationNamespacesPVCs.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/hooks/useMigrationNamespacesPVCs.ts
@@ -0,0 +1,27 @@
+import {
+  modelToGroupVersionKind,
+  PersistentVolumeClaimModel,
+} from '@kubevirt-ui/kubevirt-api/console';
+import { IoK8sApiCoreV1PersistentVolumeClaim } from '@kubevirt-ui/kubevirt-api/kubernetes';
+import { getNamespace } from '@kubevirt-utils/resources/shared';
+import useK8sWatchData from '@multicluster/hooks/useK8sWatchData';
+
+type UseMigrationNamespacesPVCs = (
+  cluster: string,
+  namespaces: string[],
+) => [IoK8sApiCoreV1PersistentVolumeClaim[], boolean, any];
+
+const useMigrationNamespacesPVCs: UseMigrationNamespacesPVCs = (cluster, namespaces) => {
+  const [pvcs, pvcsLoaded, pvcLoadError] = useK8sWatchData<IoK8sApiCoreV1PersistentVolumeClaim[]>({
+    cluster,
+    groupVersionKind: modelToGroupVersionKind(PersistentVolumeClaimModel),
+    isList: true,
+    namespaced: false,
+  });
+
+  const pvcsInNamespaces = pvcs?.filter((pvc) => namespaces.includes(getNamespace(pvc)));
+
+  return [pvcsInNamespaces, pvcsLoaded, pvcLoadError];
+};
+
+export default useMigrationNamespacesPVCs;
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/utils/migrateVMs.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/utils/migrateVMs.ts
@@ -11,7 +11,7 @@ import { getRandomChars } from '@kubevirt-utils/utils/utils';
 import { getCluster } from '@multicluster/helpers/selectors';
 import { kubevirtK8sCreate, kubevirtK8sGet, kubevirtK8sPatch } from '@multicluster/k8sRequests';
 
-export const getEmptyMigPlan = (namespace: string): MigPlan => ({
+export const getEmptyMigPlan = (namespaces: string[]): MigPlan => ({
   apiVersion: `${MigPlanModel.apiGroup}/${MigPlanModel.apiVersion}`,
   kind: MigPlanModel.kind,
   metadata: {
@@ -24,7 +24,7 @@ export const getEmptyMigPlan = (namespace: string): MigPlan => ({
       namespace: DEFAULT_MIGRATION_NAMESPACE,
     },
     liveMigrate: true,
-    namespaces: [namespace],
+    namespaces: namespaces,
     srcMigClusterRef: {
       name: 'host',
       namespace: DEFAULT_MIGRATION_NAMESPACE,
diff --git a/src/views/virtualmachines/actions/components/VirtualMachineMigration/utils/utils.ts b/src/views/virtualmachines/actions/components/VirtualMachineMigration/utils/utils.ts
diff --git a/src/views/virtualmachines/actions/hooks/useMultipleVirtualMachineActions.tsx b/src/views/virtualmachines/actions/hooks/useMultipleVirtualMachineActions.tsx
