Skip to content

Conversation

@hakman
Copy link
Member

@hakman hakman commented Nov 3, 2025

Cherry pick of #17734 on release-1.34.

#17734: azure: Avoid spurious changes in NetworkSecurityGroup

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider labels Nov 3, 2025
@hakman
Copy link
Member Author

hakman commented Nov 3, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@hakman
Copy link
Member Author

hakman commented Nov 3, 2025

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam November 3, 2025 09:42
@ameukam
Copy link
Member

ameukam commented Nov 3, 2025

we should make sure the presubmit for azure run also for release branches ?

@hakman
Copy link
Member Author

hakman commented Nov 3, 2025

we should make sure the presubmit for azure run also for release branches ?

I think we are good for now.
We should enable it by default first on master when azure-specific dirs are touched.

@ameukam
Copy link
Member

ameukam commented Nov 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7e08133 into kubernetes:release-1.34 Nov 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants