Merge pull request #17763 from Sreeja1725/dra-config-qps-burst

Configure kube-scheduler QPS and Burst

Author: k8s-ci-robot

pkg/model/components/kubescheduler/model.go

@@ -181,7 +181,7 @@ func MapToUnstructured(options interface{}, target *unstructured.Unstructured) e
 					return err
 				}
 				// Clear the field, so we don't set the flag
-				val.Set(reflect.ValueOf(nil))
+				val.Set(reflect.Zero(val.Type()))
 			default:
 				if err := setValue(targetPath, val.Interface()); err != nil {
 					return err

pkg/model/components/kubescheduler/model_test.go

@@ -21,6 +21,9 @@ import (
 	"path/filepath"
 	"testing"
 
+	"k8s.io/apimachinery/pkg/api/resource"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+	"k8s.io/kops/pkg/apis/kops"
 	"k8s.io/kops/pkg/assets"
 	"k8s.io/kops/pkg/kubemanifest"
 	"k8s.io/kops/pkg/model"
@@ -66,6 +69,51 @@ func Test_RunKubeSchedulerBuilder(t *testing.T) {
 	}
 }
 
+func Test_MapToUnstructured_WithQpsAndBurst(t *testing.T) {
+	qps := resource.MustParse("500")
+
+	kubeScheduler := &kops.KubeSchedulerConfig{
+		Qps:   &qps,
+		Burst: 500,
+	}
+
+	target := &unstructured.Unstructured{}
+	target.SetKind("KubeSchedulerConfiguration")
+	target.SetAPIVersion("kubescheduler.config.k8s.io/v1")
+
+	err := MapToUnstructured(kubeScheduler, target)
+	if err != nil {
+		t.Fatalf("MapToUnstructured failed: %v", err)
+	}
+
+	qpsVal, found, err := unstructured.NestedFloat64(target.Object, "clientConnection", "qps")
+	if err != nil {
+		t.Fatalf("error getting qps: %v", err)
+	}
+	if !found {
+		t.Error("qps not found in target")
+	}
+	if qpsVal != 500.0 {
+		t.Errorf("expected qps=500.0, got %v", qpsVal)
+	}
+
+	burst, found, err := unstructured.NestedFieldNoCopy(target.Object, "clientConnection", "burst")
+	if err != nil {
+		t.Fatalf("error getting burst: %v", err)
+	}
+	if !found {
+		t.Error("burst not found in target")
+	}
+
+	burstVal, ok := burst.(int32)
+	if !ok {
+		t.Errorf("expected burst to be int32, got %T: %v", burst, burst)
+	}
+	if burstVal != 500 {
+		t.Errorf("expected burst=500, got %v", burstVal)
+	}
+}
+
 func LoadKopsModelContext(basedir string) (*model.KopsModelContext, error) {
 	spec, err := testutils.LoadModel(basedir)
 	if err != nil {

tests/e2e/scenarios/scalability/run-test.sh

@@ -107,8 +107,8 @@ create_args+=("--set spec.kubeScheduler.authorizationAlwaysAllowPaths=/healthz")
 create_args+=("--set spec.kubeScheduler.authorizationAlwaysAllowPaths=/livez")
 create_args+=("--set spec.kubeScheduler.authorizationAlwaysAllowPaths=/readyz")
 create_args+=("--set spec.kubeScheduler.authorizationAlwaysAllowPaths=/metrics")
-create_args+=("--set spec.kubeScheduler.kubeAPIQPS=${KOPS_SCHEDULER_QPS}")
-create_args+=("--set spec.kubeScheduler.kubeAPIBurst=${KOPS_SCHEDULER_BURST}")
+create_args+=("--set spec.kubeScheduler.qps=${KOPS_SCHEDULER_QPS}")
+create_args+=("--set spec.kubeScheduler.burst=${KOPS_SCHEDULER_BURST}")
 create_args+=("--set spec.kubeScheduler.enableProfiling=true")
 create_args+=("--set spec.kubeScheduler.enableContentionProfiling=true")
 create_args+=("--set spec.kubeControllerManager.endpointUpdatesBatchPeriod=500ms")