From fe08500674d7afea7a5d681ad99f08056a99afac Mon Sep 17 00:00:00 2001 From: Felipe Yepez Date: Fri, 14 Nov 2025 11:11:47 +0000 Subject: [PATCH] Fix misleading log When processing new services, log messages could mislead to mention that the service was ignored for certain reasons that were not neccesarily true. --- pkg/l4lb/l4controller.go | 2 +- pkg/l4lb/l4netlbcontroller.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/l4lb/l4controller.go b/pkg/l4lb/l4controller.go index a6cfef6f6e..b7b4ea4b34 100644 --- a/pkg/l4lb/l4controller.go +++ b/pkg/l4lb/l4controller.go @@ -147,7 +147,7 @@ func NewILBController(ctx *context.ControllerContext, stopCh <-chan struct{}, lo if addSvc.Spec.LoadBalancerClass != nil { svcLogger.V(4).Info("Ignoring service managed by another controller", "serviceLoadBalancerClass", *addSvc.Spec.LoadBalancerClass) } else { - svcLogger.V(4).Info("Ignoring add for non-lb service", "serviceType", svcType) + svcLogger.V(4).Info("Ignoring creation of service", "serviceType", svcType) } } }, diff --git a/pkg/l4lb/l4netlbcontroller.go b/pkg/l4lb/l4netlbcontroller.go index f5548685a8..27fc031ffb 100644 --- a/pkg/l4lb/l4netlbcontroller.go +++ b/pkg/l4lb/l4netlbcontroller.go @@ -155,7 +155,7 @@ func NewL4NetLBController( l4netLBc.svcQueue.Enqueue(addSvc) l4netLBc.enqueueTracker.Track() } else { - svcLogger.V(4).Info("Ignoring add for non external lb service") + svcLogger.V(4).Info("Ignoring creation of service") } }, // Deletes will be handled in the Update when the deletion timestamp is set.