-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Description
IMHO, Ideally we should remove all these helper dependencies from the cloud-provider
grep -r "k8s.io/cloud-provider/service/helpers" pkg/
pkg/l4lb/l4netlbcontroller_test.go: "k8s.io/cloud-provider/service/helpers"
pkg/l4lb/l4lbcommon.go: "k8s.io/cloud-provider/service/helpers"
pkg/utils/patch/patch.go: svchelpers "k8s.io/cloud-provider/service/helpers"
pkg/neg/controller.go: "k8s.io/cloud-provider/service/helpers"
pkg/loadbalancers/l4netlb_test.go: servicehelper "k8s.io/cloud-provider/service/helpers"
pkg/loadbalancers/l4netlb.go: "k8s.io/cloud-provider/service/helpers"
pkg/loadbalancers/l4.go: "k8s.io/cloud-provider/service/helpers"
pkg/loadbalancers/l4_test.go: servicehelper "k8s.io/cloud-provider/service/helpers"
pkg/healthchecksl4/healthchecksl4.go: "k8s.io/cloud-provider/service/helpers"
cc: @swetharepakula
Originally posted by @aojea in #1896 (comment)
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.